Bugs item #2784162, was opened at 2009-04-30 02:25 Message generated for change (Settings changed) made by russblau You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2784162...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: rewrite Group: None
Status: Closed Resolution: Fixed
Priority: 5 Private: No Submitted By: NicDumZ — Nicolas Dumazet (nicdumz) Assigned to: Russell Blau (russblau) Summary: pagebacklinks(followRedirects=True) doesnt yield redirects
Initial Comment: I don't understand why there is, on site.py:1108 : blgen.request["gblfilterredir"] = "nonredirects"
With that line, if you set up 3 pages : [[fruits]] : Hey, fruits are healthy!! [[orange]] : #REDIRECT [[fruits]] [[mandarine]] : Mandarines are like [[orange]]s, but different.Yeah.
[[fruits]].backlinks() will only yield [[mandarine]]. [[orange]] will be missing (default values are followRedirects=True, filterRedirects=None, so I would expect [[orange]] too.)
If I remove that line 1108, the results look correct again, and [[orange]] is yielded. Is this an appropriate fix?
There is also an ambiguity for (followRedirects=True, filterRedirects=True): I'm not sure of what should be expected as a return value: * We also iterate over links that are linked to the current page through a current page * But we are supposed to yield only redirects? if I'm correct the result of (followRedirects=True, filterRedirects=True) should be the same as (followRedirects=False, filterRedirects=True) ? Or we would have to also yield double-redirects? =)
----------------------------------------------------------------------
Comment By: Russell Blau (russblau)
Date: 2009-05-04 16:43
Message: fixed in r6821
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2784162...