valhallasw added a comment.
I think that instead of the current
try: (response, content) = httplib2.Http.request( self, uri, method, body, headers, max_redirects, connection_type ) except Exception as e: # what types? # return exception instance to be retrieved by the calling thread return e
wrapper, we should actually just wrap all of `def request` with a try-catch block which returns e on error. Does that sound like the right solution to you?
TASK DETAIL https://phabricator.wikimedia.org/T78123
REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, valhallasw Cc: Aklapper, jayvdb, valhallasw, pywikipedia-bugs