Bugs item #1754881, was opened at 2007-07-16 18:47 Message generated for change (Settings changed) made by xqt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1754881...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: interwiki Group: None
Status: Closed Resolution: Out of Date
Priority: 5 Private: No Submitted By: Tomasz Sienicki (tsca) Assigned to: Nobody/Anonymous (nobody) Summary: self.interwiki_text_separator & interwiki attop
Initial Comment: When interwiki links are added attop, the self.interwiki_text_separator variable should be set to '' (instead of '\r\n\r\n').
The setting as it is now ('\r\n\r\n') causes empty lines to appear at the top of the articles.
Alternatively this could be configurable per project (though I don't believe any project would want their entries to begin with two empty lines).
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2009-10-17 17:58
Message: Possibly changed in r6172
----------------------------------------------------------------------
Comment By: Purodha B Blissenbach (purodha) Date: 2007-07-17 05:12
Message: Logged In: YES user_id=46450 Originator: NO
These settings are imho not correctly object-oriented, which is wrong, or bad style, which should be changed.
Imho, it is ok to have these settings be set per family, as it is currently done. But, they should be inherited by the language/wiki, which isn't currently so Finally any specific wiki project should be able to alter them individually, which is currently impossible.
Also, the separator treatment is currently wrong. As it happens to be, separators get accidentally removed, since they are made up from a number of \r's and \n's, which get stripped anyway. If you alter the separator, this is no more the case, and interwiki.py / categories.py move all existing separators to one place, and add one or two new separators upon each invocation. This is imho highly undesirable.
I suggest to correctly remove existing separators together with the categories / interwikies, when they are removed, and insert exactly one of them, when categories / interwikies are inserted, or reinserted.
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603138&aid=1754881...