Feature Requests item #1722782, was opened at 2007-05-21 17:21 Message generated for change (Comment added) made by xqt You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603141&aid=1722782...
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update.
Category: interwiki
Group: None
Status: Closed
Priority: 5 Private: No Submitted By: Byrial Ole Jensen (byrial)
Assigned to: xqt (xqt)
Summary: interwiki.py should follow category redirect templates
Initial Comment: Sometimes when a category is moved, a template like [[en:template:Template:Category redirect]] (see its interwiki links for similar templates in other languages) is left at the old category page.
It would be good if interwiki.py could check for the presence of a such template and follow the redirect to the new category as given by the template argument.
----------------------------------------------------------------------
Comment By: xqt (xqt)
Date: 2010-02-16 08:09
Message: category redirects are handled similar to normal redirects since release 7936 (fix for #2949822). This also affects -initialredirect and -noredirect as well
----------------------------------------------------------------------
Comment By: Lars Aronsson (aronsson) Date: 2009-01-17 17:34
Message: Could you describe how you measure this slowdown, and what level of slowdown would be acceptable? All the code does is to test for strings similar to {{category redirect | something}}, which shouldn't be much slower than testing for #REDIRECT [[something]].
----------------------------------------------------------------------
Comment By: Russell Blau (russblau) Date: 2009-01-15 15:45
Message: aronsson: Although your patch works, it causes an unacceptable slowdown in the loading of category pages. I have therefore reverted the change, and will not implement this feature for the time being. I'll leave this open in case anyone has a better idea.
----------------------------------------------------------------------
Comment By: Lars Aronsson (aronsson) Date: 2009-01-12 23:22
Message: The previous comment was a failed attempt to submit a patch. The same code is available as the attached file mydiff. Most of this patch is a list of template names, that originated in category_redirect.py and really should move to family.py or some place like that.
What I've done is to add an "elif" branch in the two places, where self.site.redirectRegex() is tested, so it also looks for these templates, but only if we are in a category page. Maybe self.site shouldn't hand out a regex, but instead provide the function that tests for redirects. Feel free to refactor this.
----------------------------------------------------------------------
Comment By: Lars Aronsson (aronsson) Date: 2009-01-10 02:41
Message: Thanks, I hadn't even looked in category_redirect.py. For the moment, I just copied the list of template names to my version of wikipedia.py so all my changes are in one file. I have updated the list with more template names (and more synonyms).
The detection of #REDIRECT in wikipedia.py is done in two places, using self.site.redirectRegex() both in Page._getEditPage() and GetAll.oneDone(). These are the two places I added an "elif" branch to look for category redirects. I don't fully understand why there needs to be two places to do this test, but that's a matter of overall design. The naming of redirectRegex() is also hardwired to the use of a single regex, which doesn't scale to category redirects. Perhaps a refactoring would lead to that function being renamed to isRedirect(). I think redirect detection does belong in the Site object, since it depends on language-specific synonyms to REDIRECT and to specific templates used for category redirects.
----------------------------------------------------------------------
Comment By: Russell Blau (russblau) Date: 2009-01-09 14:17
Message: category_redirect.py already contains a list of category redirect templates, although only for a few sites. If it is desired to use this capability in other bots, then the template lists should probably be moved into the family files, and an is_category_redirect() method added to the Category object in catlib.py, or alternatively to the Page object.
----------------------------------------------------------------------
Comment By: Lars Aronsson (aronsson) Date: 2009-01-09 12:40
Message: I now have some code that I believe solves this. But since I'm a beginner in Python, I'd like someone more experienced to look at my code before it is submitted.
----------------------------------------------------------------------
Comment By: Lars Aronsson (aronsson) Date: 2009-01-09 01:46
Message: The previous comment was by me. I don't know why I wasn't logged in.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody) Date: 2009-01-09 01:43
Message: Implementing this feature involves several steps.
First the template needs to be detected. This is similar to isDisambig() in wikipedia.py. Perhaps that function should also require isCategory(), so the template is only detected when used in category pages. Unfortunately, there is no equivalent to the MediaWiki:Disambiguationspage to help us find out what the template name is in each language, so we have to list the template translations for each language. I think that should be manageable.
I propose the new function be called isCategoryRedirect(). Then this function needs to be introduced where isRedirect() is used. Or perhaps isRedirect() should call it? That would save a lot of work.
Are there some situations where it would be harmful to detect this template? Should the use of the new function be configurable?
----------------------------------------------------------------------
You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=603141&aid=1722782...