Patches item #2781280, was opened at 2009-04-25 21:38
Message generated for change (Settings changed) made by nicdumz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Tieum P (tieump)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for incorrect interwikis removal (bug#2780256)
Initial Comment:
Please find attached patch that solve problem in bug #2780256
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2009-04-26 04:54
Message:
Yes! Correct!
Thanks for helping
It came from r6992:
- if page in self.done: #XXX: Ugly bugfix - the
following line has reportedly thrown "ValueError: list.remove(x): x not in
list"
- self.done.remove(page)
+ self.done = PageTree()
My tired eyes were reading "for page in self.done", which was... indeed a
very Ugly bugfix.
I applied a modified version of your patch in r6721. Thanks ;)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280&group_…
Patches item #2781280, was opened at 2009-04-25 21:38
Message generated for change (Settings changed) made by nicdumz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Tieum P (tieump)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for incorrect interwikis removal (bug#2780256)
Initial Comment:
Please find attached patch that solve problem in bug #2780256
----------------------------------------------------------------------
>Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2009-04-26 04:54
Message:
Yes! Correct!
Thanks for helping
It came from r6992:
- if page in self.done: #XXX: Ugly bugfix - the
following line has reportedly thrown "ValueError: list.remove(x): x not in
list"
- self.done.remove(page)
+ self.done = PageTree()
My tired eyes were reading "for page in self.done", which was... indeed a
very Ugly bugfix.
I applied a modified version of your patch in r6721. Thanks ;)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280&group_…
Patches item #2781435, was opened at 2009-04-26 04:49
Message generated for change (Tracker Item Submitted) made by zedlik
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781435&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Translations
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: zedlik (zedlik)
Assigned to: Nobody/Anonymous (nobody)
Summary: +be-x-old for featured.py
Initial Comment:
Edit summary text for be-x-old for featured.py.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781435&group_…
Bugs item #2780256, was opened at 2009-04-24 08:35
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2780256&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: interwiki
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Removing of interwiki
Initial Comment:
I run my bot with -force parameter for some pages, but bot removed valid interwiki from this aricle (I tried it for other languages too):
interwiki.py -force en:Energy conversion efficiency
http://cs.wikipedia.org/w/index.php?title=%C3%9A%C4%8Dinnost_(fyzika)&diff=…http://en.wikipedia.org/w/index.php?title=Energy_conversion_efficiency&diff…http://eo.wikipedia.org/w/index.php?title=Efikeco&diff=2278810&oldid=2275073
I have python 2.5 and pywikipedia Revision 6695
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-25 19:49
Message:
I had downloaded latest night (2009-04-23) build + newest interwiki.py. I
run it on couple of pages, only three (two mentioned without mixed
interwiki and one with mixed interwiki
http://cs.wikipedia.org/w/index.php?title=Druh%C3%A1_v%C3%ADde%C5%88sk%C3%A…
)
After that I reverted back to version from night build
----------------------------------------------------------------------
Comment By: Tieum P (tieump)
Date: 2009-04-25 18:05
Message:
This is not due to -force. From my early investigations, it happens when
there are duplicates interwikis. I am trying to cxome up with a patch as I
type.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-25 16:01
Message:
Well, first of all thanks for reporting this/looking into the issue.
I've been looking carefully, twice, at the unified r6691:6695 diff, and I
can't find anything that would change the behavior of the bot.
Are you 100% that 6991 is fine?
In particular, nothing changes the -force behavior : (-force just never
asks you about changes), it means that it should happen quite often.
I have tried reproducing this bug, but I can't for now. Do you have a
minimal testcase that would trigger the said behavior? aka something that
would happen precisely in r6695, but not in r6691 ?
----------------------------------------------------------------------
Comment By: Tieum P (tieump)
Date: 2009-04-25 15:16
Message:
I looked a little bit into this.
r6691 works fine
r6692 thru r6694 are broken (code will not even run)
r6695 shows the bug reported here
I would suggest falling back to r6691 for now
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-24 08:41
Message:
NExt one:
http://cs.wikipedia.org/w/index.php?title=Fanta&diff=prev&oldid=3884413
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2780256&group_…
Patches item #2781280, was opened at 2009-04-25 15:38
Message generated for change (Tracker Item Submitted) made by tieump
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Tieum P (tieump)
Assigned to: Nobody/Anonymous (nobody)
Summary: Patch for incorrect interwikis removal (bug#2780256)
Initial Comment:
Please find attached patch that solve problem in bug #2780256
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603140&aid=2781280&group_…
Bugs item #2780256, was opened at 2009-04-24 04:35
Message generated for change (Comment added) made by tieump
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2780256&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: interwiki
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Removing of interwiki
Initial Comment:
I run my bot with -force parameter for some pages, but bot removed valid interwiki from this aricle (I tried it for other languages too):
interwiki.py -force en:Energy conversion efficiency
http://cs.wikipedia.org/w/index.php?title=%C3%9A%C4%8Dinnost_(fyzika)&diff=…http://en.wikipedia.org/w/index.php?title=Energy_conversion_efficiency&diff…http://eo.wikipedia.org/w/index.php?title=Efikeco&diff=2278810&oldid=2275073
I have python 2.5 and pywikipedia Revision 6695
----------------------------------------------------------------------
Comment By: Tieum P (tieump)
Date: 2009-04-25 14:05
Message:
This is not due to -force. From my early investigations, it happens when
there are duplicates interwikis. I am trying to cxome up with a patch as I
type.
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-25 12:01
Message:
Well, first of all thanks for reporting this/looking into the issue.
I've been looking carefully, twice, at the unified r6691:6695 diff, and I
can't find anything that would change the behavior of the bot.
Are you 100% that 6991 is fine?
In particular, nothing changes the -force behavior : (-force just never
asks you about changes), it means that it should happen quite often.
I have tried reproducing this bug, but I can't for now. Do you have a
minimal testcase that would trigger the said behavior? aka something that
would happen precisely in r6695, but not in r6691 ?
----------------------------------------------------------------------
Comment By: Tieum P (tieump)
Date: 2009-04-25 11:16
Message:
I looked a little bit into this.
r6691 works fine
r6692 thru r6694 are broken (code will not even run)
r6695 shows the bug reported here
I would suggest falling back to r6691 for now
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-24 04:41
Message:
NExt one:
http://cs.wikipedia.org/w/index.php?title=Fanta&diff=prev&oldid=3884413
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2780256&group_…
Bugs item #2780256, was opened at 2009-04-24 08:35
Message generated for change (Comment added) made by nobody
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2780256&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: interwiki
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Removing of interwiki
Initial Comment:
I run my bot with -force parameter for some pages, but bot removed valid interwiki from this aricle (I tried it for other languages too):
interwiki.py -force en:Energy conversion efficiency
http://cs.wikipedia.org/w/index.php?title=%C3%9A%C4%8Dinnost_(fyzika)&diff=…http://en.wikipedia.org/w/index.php?title=Energy_conversion_efficiency&diff…http://eo.wikipedia.org/w/index.php?title=Efikeco&diff=2278810&oldid=2275073
I have python 2.5 and pywikipedia Revision 6695
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-25 16:01
Message:
Well, first of all thanks for reporting this/looking into the issue.
I've been looking carefully, twice, at the unified r6691:6695 diff, and I
can't find anything that would change the behavior of the bot.
Are you 100% that 6991 is fine?
In particular, nothing changes the -force behavior : (-force just never
asks you about changes), it means that it should happen quite often.
I have tried reproducing this bug, but I can't for now. Do you have a
minimal testcase that would trigger the said behavior? aka something that
would happen precisely in r6695, but not in r6691 ?
----------------------------------------------------------------------
Comment By: Tieum P (tieump)
Date: 2009-04-25 15:16
Message:
I looked a little bit into this.
r6691 works fine
r6692 thru r6694 are broken (code will not even run)
r6695 shows the bug reported here
I would suggest falling back to r6691 for now
----------------------------------------------------------------------
Comment By: Nobody/Anonymous (nobody)
Date: 2009-04-24 08:41
Message:
NExt one:
http://cs.wikipedia.org/w/index.php?title=Fanta&diff=prev&oldid=3884413
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2780256&group_…
Bugs item #2781005, was opened at 2009-04-25 06:46
Message generated for change (Comment added) made by nicdumz
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2781005&group_…
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: interwiki
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: interwiki.py empties category page with templates
Initial Comment:
Operating on category pages, when zh:Category: need to be modified to zh:分类: and there is a template in category page, interwiki.py seems to remove all the contents of the page. Below 3 buggy edits done by my bot. Thanks for looking into this - en:User:Jacob.jose
1. http://en.wikipedia.org/w/index.php?title=Category:Olympic_gold_medalists_f…
2. http://en.wikipedia.org/w/index.php?title=Category:Public_utilities&diff=pr…
3. http://ja.wikipedia.org/w/index.php?title=Category:%E3%83%AA%E3%83%92%E3%83…
However, below edits are ok:
1. http://en.wikipedia.org/w/index.php?title=Category:Roman_Catholic_dioceses_…
2. http://en.wikipedia.org/w/index.php?title=Category:Painters&action=edit&old…
Version:
Pywikipedia [http] trunk/pywikipedia (r6564, Mar 28 2009, 17:27:58)
Python 2.5.1 (r251:54863, Apr 18 2007, 08:51:08) [MSC v.1310 32 bit (Intel)]
----------------------------------------------------------------------
>Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2009-04-25 07:17
Message:
A sentence has been left out from previous comment:
"Please update your local copy, and try to reproduce the bug with that
newer version"
----------------------------------------------------------------------
Comment By: NicDumZ — Nicolas Dumazet (nicdumz)
Date: 2009-04-25 07:15
Message:
hello, thanks for the report.
Your version of pywikipedia is one month old. Current revision number is
r6695, meaning that more than one hundred changes were done to the
framework in the meantime.
The zh: Category namespace name, in particular, have been updated since.
By the way an edit like
http://en.wikipedia.org/w/index.php?title=Category:Painters&diff=283488201&…
does not seem correct to me: [[zh:分类:画家]] is as valid as
[[zh:Category:画家]], I don't see why we'd need a _standalone_ edit to
change the namespace name. It's okay to normalize namespaces when adding or
modifying content; it's not okay to edit just to change a namespace name.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2781005&group_…