jayvdb added a comment.
In https://phabricator.wikimedia.org/T72970#1000805, @XZise wrote:
> There is a WARNING level which is always shown and there are warnings which aren't shown by default.
are you referring to the tools warnings shown on travis? I believe that is a separate problem relating to how some tests are run before 'bot' initialisation. There are ui_tests for warning, but they probably dont check that warnings are not shown if the logging subsystem is set at error level.
With regards to warnings.warn we should be setting the warnings filters to honour the config settings. The warnings regarding config are subclasses of UserWarning, which are shown by default. Currently, the warnings about config problems were using 'print' and thus were previously always shown (i.e. they were not warnings) . The warnings regarding arguments will likely change a bit when we move to argparse, so we should consider that in the implementation of warnings.
TASK DETAIL
https://phabricator.wikimedia.org/T72970
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
Cc: XZise, gerritbot, Nullzero, jayvdb, pywikipedia-bugs
valhallasw created this task.
valhallasw added a subscriber: valhallasw.
valhallasw added a project: pywikibot-core.
TASK DESCRIPTION
`bot.debug` has a different interface from all other logging functions:
```
def debug(text, layer, decoder=None, newline=True, **kwargs):
```
versus
```
def error(text, decoder=None, newline=True, **kwargs):
```
We should deprecate `layer`, for `_logger`, passed as kwarg (in debug) or the other way around (for all other functions).
TASK DETAIL
https://phabricator.wikimedia.org/T85620
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: valhallasw
Cc: Aklapper, valhallasw, jayvdb, pywikipedia-bugs
Chad added a comment.
An hour? More like done except a couple of busted repos which is unrelated to this.
TASK DETAIL
https://phabricator.wikimedia.org/T87248
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Chad
Cc: Krinkle, XZise, valhallasw, JanZerebecki, Nikerabbit, siebrand, cpa199, zhaofengli, llbraughler, adrianheine, Krenair, Xqt, jayvdb, fbstj, greg, Legoktm, Chad, MarkTraceur, matmarex, UltrasonicNXT, Aklapper, QChris, pywikipedia-bugs