Ladsgroup added a comment.
Sorry for not making the notice in the mailing lists, I was traveling for a while, I reached my final destination five hours ago.
Anyway, I made the notice. Thank you
TASK DETAIL
https://phabricator.wikimedia.org/T100707
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: RobH, Ladsgroup
Cc: zhuyifei1999, gerritbot, valhallasw, Multichill, Ladsgroup, Aklapper, JohnLewis, RobH, jayvdb, Jalexander, mark, faidon, fgiunchedi, Dzahn, chasemp, pywikipedia-bugs
zhuyifei1999 created this task.
zhuyifei1999 added subscribers: zhuyifei1999, XZise.
zhuyifei1999 added projects: pywikibot-core, Pywikibot-General.
Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION
On an upload of "File:Scanwings, OH-BCX, Beechcraft C90 King Air (17512831479).jpg" to Commons:
Using HEAD, upload fail with a loophole of
```
ERROR: Traceback (most recent call last):
File "/data/project/yifeibot/pywikibot/pywikibot/data/api.py", line 1555, in submit
body=body, headers=headers)
File "/data/project/yifeibot/pywikibot/pywikibot/tools/__init__.py", line 950, in wrapper
return obj(*__args, **__kw)
File "/data/project/yifeibot/pywikibot/pywikibot/comms/http.py", line 269, in request
r = fetch(baseuri, method, body, headers, **kwargs)
File "/data/project/yifeibot/pywikibot/pywikibot/comms/http.py", line 370, in fetch
error_handling_callback(request)
File "/data/project/yifeibot/pywikibot/pywikibot/comms/http.py", line 287, in error_handling_callback
raise request.data
UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 1872: ordinal not in range(128)
WARNING: Waiting 5 seconds before retrying.
```
After debugging, I found all versions after 1e54a7d6886d56a21101900025038e25bab5ad03 has the same error, while version before raises an (expected) exception that is handled in botscript:
```
KeyError: u'bad-prefix'
```
(raised in https://github.com/wikimedia/mediawiki/blob/84899f991ff44f36b7359f0bbf8de29…)
I agree that some errors should be prevented from uploading. But why is there a UnicodeDecodeError leading to a loophole?
TASK DETAIL
https://phabricator.wikimedia.org/T99366
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: zhuyifei1999
Cc: XZise, Aklapper, zhuyifei1999, jayvdb, pywikipedia-bugs
jayvdb closed this task as "Resolved".
jayvdb claimed this task.
jayvdb added a comment.
This problem may still exist in lesser-used parts of wikipedia.py , but no other cases have been identified. Re-open or mention this task if other cases are found.
TASK DETAIL
https://phabricator.wikimedia.org/T74749
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
Cc: Xqt, He7d3r, jayvdb, Anshoe, pywikipedia-bugs
jayvdb created this task.
jayvdb added subscribers: pywikipedia-bugs, jayvdb.
jayvdb added a project: pywikibot-core.
Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION
-start is a pagegen argument, but it is also implemented in
* checkimages.py
* misspelling.py
* pagefromfile.py
* redirect.py
* solve_disambiguation.py
* states_redirect.py
misspelling.py, redirect.py and solve_disambiguation.py have their own -start because they support dumps, which are not supported by pagegen: T85334
interwiki.py also has -start_id
TASK DETAIL
https://phabricator.wikimedia.org/T100628
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
Cc: jayvdb, Aklapper, pywikipedia-bugs
jayvdb created this task.
jayvdb added subscribers: greg, pywikipedia-bugs, jayvdb, Aklapper.
jayvdb added projects: Pywikibot-tests, pywikibot-core.
TASK DESCRIPTION
If loading the initialisation of ParamInfo was successful, some of the core API modules are working correctly.
If then loading a batch of modules causes a server error, the paraminfo class could retry the batch by loading paraminfo for one module at a time, and report which module fails.
Another option is to avoid loading non-core modules, or avoid loading all modules to determine prefixes.
This should make pywikibot more resilient for when defective modules deployed to a wiki, and result in quicker & better errors reported to WMF ops / release managers.
(Currently WMF test and beta wikis have such a defective module : T100775 , so fixing this quickly may be necessary in case Wikimedia dont revert / fix the problem)
TASK DETAIL
https://phabricator.wikimedia.org/T100779
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
Cc: Aklapper, jayvdb, greg, pywikipedia-bugs