Xqt created this task.
Xqt added a subscriber: Xqt.
Xqt added a project: pywikibot-core.
Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION
ISBN.py wrongly breaks while formatting the ISBN.
command line was:
```
pwb.py isbn -page:Franz-Eher-Verlag -Format -lang:de -simulate
```
The ISBN is ISBN 3-00-013343-7 which is correct and exists [1]. But the script fails.
[1] https://portal.dnb.de/opac.htm?referrer=Wikipedia&method=enhancedSearch&ind…
```
Traceback (most recent call last):
File "C:\pwb\SVN\core\pwb.py", line 228, in <module>
run_python_file(filename, argv, argvu, file_package)
File "C:\pwb\SVN\core\pwb.py", line 85, in run_python_file
main_mod.__dict__)
File ".\scripts\isbn.py", line 1662, in <module>
main()
File ".\scripts\isbn.py", line 1657, in main
bot.run()
File ".\scripts\isbn.py", line 1526, in run
self.treat(page)
File ".\scripts\isbn.py", line 1504, in treat
new_text = self.isbnR.sub(_hyphenateIsbnNumber, new_text)
File ".\scripts\isbn.py", line 1415, in _hyphenateIsbnNumber
i.format()
File ".\scripts\isbn.py", line 1334, in format
ISBN.format(self)
File ".\scripts\isbn.py", line 1225, in format
% self.code)
__main__.InvalidIsbnException: ISBN 3-00-013343-7: publisher number unknown.
<class '__main__.InvalidIsbnException'>
CRITICAL: Waiting for 1 network thread(s) to finish. Press ctrl-c to abort
```
TASK DETAIL
https://phabricator.wikimedia.org/T97887
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt
Cc: pywikipedia-bugs, Xqt, Aklapper, jayvdb
Xqt created this task.
Xqt added a subscriber: Xqt.
Xqt added projects: Pywikibot-Cosmetic-changes, pywikibot-core.
Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION
```
Exception in thread Put-Thread:
Traceback (most recent call last):
File "C:\Python27\lib\threading.py", line 810, in __bootstrap_inner
self.run()
File "C:\Python27\lib\threading.py", line 763, in run
self.__target(*self.__args, **self.__kwargs)
File "C:\pwb\SVN\core\pywikibot\__init__.py", line 717, in async_manager
request(*args, **kwargs)
File "C:\pwb\SVN\core\pywikibot\page.py", line 1050, in _save
comment = self._cosmetic_changes_hook(comment) or comment
File "C:\pwb\SVN\core\pywikibot\page.py", line 1101, in _cosmetic_changes_hook
self.text = ccToolkit.change(old)
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 291, in change
new_text = self._change(text)
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 285, in _change
text = self.safe_execute(method, text)
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 272, in safe_execute
result = method(text)
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 955, in fix_ISBN
text, strict=False if self.ignore == CANCEL_MATCH else True)
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 219, in _reformat_ISBNs
text, lambda match: _format_isbn_match(match, strict=strict))
File "C:\pwb\SVN\core\pywikibot\textlib.py", line 1248, in reformat_ISBNs
text = isbnR.sub(match_func, text)
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 219, in <lambda>
text, lambda match: _format_isbn_match(match, strict=strict))
File "C:\pwb\SVN\core\scripts\cosmetic_changes.py", line 201, in _format_isbn_match
isbn.format()
File "C:\pwb\SVN\core\scripts\isbn.py", line 1329, in format
ISBN.format(self)
File "C:\pwb\SVN\core\scripts\isbn.py", line 1220, in format
% self.code)
InvalidIsbnException: ISBN 3-00-013343-7: publisher number unknown.
```
TASK DETAIL
https://phabricator.wikimedia.org/T97836
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Xqt
Cc: pywikipedia-bugs, Xqt, Aklapper, jayvdb
saper created this task.
saper added a subscriber: saper.
saper added a project: Pywikibot-General.
Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION
Having configured pywikibot with python `logging` module there is little need for this feature.
This feature insists on checking pywikibot version which may cause problems like inability to locate `git` or lack of SSL certificate for tools.wmflabs.org {T98104}.
It should be optional (config entry?)
TASK DETAIL
https://phabricator.wikimedia.org/T98106
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: saper
Cc: pywikipedia-bugs, saper, Aklapper
saper created this task.
saper added a subscriber: saper.
saper added a project: Pywikibot-General.
Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION
I run my bots in a fairly constrained and controlled environment (minimal software configuration, constrained permissions and network traffic) and I am running into problems like pywikibot trying to guess the version number.
I have proposed a Gerrit change to [override User-Agent](https://gerrit.wikimedia.org/r/#/c/208842/). Apparently `pywikibot-core` has a `config.user_agent_format` feature but it does not prevent auto-discovery of the bot version.
Overriding User-Agent is not enough since there may be more features checking the version, one of them is `writeToCommandLogFile()` (see also {T98106}).
When git is not available, it tries to fetch the irrelevant changelog, as I usually have some local patches/commits in the code. (Fetching also fails with {T98104}).
This feature is just not robust enough in my experience.
TASK DETAIL
https://phabricator.wikimedia.org/T98107
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: saper
Cc: pywikipedia-bugs, saper, Aklapper
Mpaa created this task.
Mpaa added a subscriber: Mpaa.
Mpaa added a project: pywikibot-core.
Restricted Application added subscribers: Aklapper, pywikipedia-bugs.
TASK DESCRIPTION
At the first call, page.text or page.get() submit two similar requests.
Moreover, page.get() does not use cached data as commented in code but reload every time the page.
This is due to the use of page.latest_revision.text in get().
[debug print inserted in request.submit()]
```
>>> page.text
SUBMIT /w/api.php?continue=&rvprop=ids|flags|timestamp|user|comment|content&prop=info|revisions&titles=User:Mpaa/y&indexpageids=&action=query
SUBMIT /w/api.php?action=query&meta=userinfo&uiprop=blockinfo|hasmsg|groups|rights
SUBMIT /w/api.php?continue=&rvprop=ids|flags|timestamp|user|comment|content&prop=info|revisions&action=query&titles=User:Mpaa/y&indexpageids=&rvlimit=1&rvdir=older
u'yet another'
```
TASK DETAIL
https://phabricator.wikimedia.org/T97960
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Mpaa
Cc: pywikipedia-bugs, Aklapper, Mpaa, jayvdb