jayvdb reopened this task as "Open".
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.
Unfortunately, we have many bugs about this, and the root of the problem was the addition of 'qualifier' and 'source' to the design.
I am using T69284 as the spot to fix this.
TASK DETAIL
https://phabricator.wikimedia.org/T56415
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, Legoktm, Strainu, Xqt, jayvdb
jayvdb merged this task into T69284: claimit.py should add another value but not duplicate.
TASK DETAIL
https://phabricator.wikimedia.org/T57002
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, Legoktm, Strainu, jayvdb
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.
Unfortunately, the code merged for T56415 allows duplicate values, and is buggy, pretty much by design.
TASK DETAIL
https://phabricator.wikimedia.org/T57002
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, Legoktm, Strainu, jayvdb
gerritbot added a comment.
Change 92073 abandoned by John Vandenberg:
Enable adding statements on items with the same property, but different values.
Reason:
My bad, yes it did.
[[https://gerrit.wikimedia.org/r/92073]]
TASK DETAIL
https://phabricator.wikimedia.org/T56415
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: gerritbot
Cc: pywikipedia-bugs, Legoktm, Strainu, Xqt
gerritbot added a comment.
Change 92073 restored by John Vandenberg:
Enable adding statements on items with the same property, but different values.
Reason:
The GCI code didnt check for duplicates like APAC's code does
[[https://gerrit.wikimedia.org/r/92073]]
TASK DETAIL
https://phabricator.wikimedia.org/T56415
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: gerritbot
Cc: pywikipedia-bugs, Legoktm, Strainu, Xqt
jayvdb added a subscriber: jayvdb.
jayvdb added a comment.
Can you provide a real example of how this would be used?
TASK DETAIL
https://phabricator.wikimedia.org/T69568
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, Matanya, JAnD, jayvdb
jayvdb added a blocking task: T69284: claimit.py should add another value but not duplicate.
TASK DETAIL
https://phabricator.wikimedia.org/T72702
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, JAnD, jayvdb
jayvdb changed the title from "claimit.py should get list of Q for a property" to "claimit.py : add a list of Q to a property".
jayvdb removed a subscriber: Unknown Object (????).
jayvdb set Security to none.
TASK DETAIL
https://phabricator.wikimedia.org/T75398
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb, Yamaha5