XZise created this task.
XZise added a subscriber: XZise.
XZise added a project: pywikibot-core.
TASK DESCRIPTION
When using `-debug` it causes an exception on exit:
`$ python pwb.py touch -family:beta -lang:en -page:0.5332966154956742 -debug
Retrieving 1 pages from beta:en.
Sleeping for 8.8 seconds, 2014-12-30 01:32:09
Page [[0.5332966154956742]] saved
--- Logging error ---
Traceback (most recent call last):`
This is all, there is no traceback. I'm using Python 3.4.2.
I'm also not sure if the log rotation does work. It creates one file and overwrites it over and over again (although that happens also with `-log`).
TASK DETAIL
https://phabricator.wikimedia.org/T85500
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise
Cc: Aklapper, XZise, jayvdb, pywikipedia-bugs
jayvdb created this task.
jayvdb assigned this task to Omegat.
jayvdb added subscribers: pywikipedia-bugs, jayvdb, XZise, Grunny.
jayvdb added projects: PyWikiBot-Interwiki-Map, pywikibot-core, Pywikibot-tests.
jayvdb changed Security from none to none.
TASK DESCRIPTION
Search on the Wikia website appears to work fine
http://www.wikia.com/Special:Search?search=foo&fulltext=Searchhttp://www.wikia.com/Special:Search?search=Seuss&fulltext=Search
But errors result from calling the api, search on text or title
http://www.wikia.com/api.php?format=jsonfm&action=query&generator=search&gs…http://www.wikia.com/api.php?format=jsonfm&action=query&generator=search&gs…
But a near match search does appear to be working.
http://www.wikia.com/api.php?format=jsonfm&action=query&generator=search&gs…
but not returning results which do appear on the search page.
http://www.wikia.com/api.php?format=jsonfm&action=query&generator=search&gs…
This is causing a test error in site_tests.SiteUserTestCase.testSearch
```
Traceback (most recent call last):
File "./tests/site_tests.py", line 887, in testSearch
se = list(mysite.search("wiki", total=100))
File "./pywikibot/data/api.py", line 1452, in __iter__
self.data = self.request.submit()
File "./pywikibot/data/api.py", line 1071, in submit
raise APIError(code, info, **result["error"])
pywikibot.data.api.APIError: gsrsearch-text-disabled: text search is disabled
```
The simplest fix for the test suite is to catch and detect 'gsrsearch-text-disabled' - when the API returns that error, use unittest.SkipTest to skip the test without causing a test failure.
Longer term pywikibot needs to detect that search is disabled, like we detect whether upload is enabled in APISite.is_uploaddisabled.
TASK DETAIL
https://phabricator.wikimedia.org/T77968
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: Omegat, jayvdb
Cc: Aklapper, jayvdb, XZise, Grunny, pywikipedia-bugs
Benjavalero created this task.
Benjavalero added a subscriber: Benjavalero.
Benjavalero added a project: pywikibot-core.
Benjavalero changed Security from none to none.
TASK DESCRIPTION
I am proposing in this issue a patch to improve the algorithm to replace text with exceptions. I have found that the current algorithm process the exception regexes many times, and this can be avoided. In my tests, with my patch in long text pages I obtain significant performance improvements.
I understand this patch touches a critical part of the pywikibot code, so unit tests should be provided, but I am Python newbie and I am afraid that testing in Python is a little out of my knowledge without a bit of guidance.
I hope you could test the patch and confirm my results.
TASK DETAIL
https://phabricator.wikimedia.org/T85037
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Benjavalero
Cc: Aklapper, Benjavalero, jayvdb, pywikipedia-bugs
jayvdb added a comment.
Well, ideally neither is 'moved' as such, but -yesterday and -recentchanges are replaced with standard pagegenerator arguments where possible to achieve the same result, e.g." -uploadlog" and generic pagegenerators / filters are used where not possible.
For providing backwards compatibility for '-yesterday' , you can do something like
if arg == '-yesterday':
gen.handleArg('-uploadlog')
Then you need to restrict the date range of the upload log to 'yesterday'. To restrict the date, add an EdittimeFilterPageGenerator after calling getCombinedGenerator.
However currently EdittimeFilterPageGenerator will continue to consume all entries outside of the date range(which could take forever); we need an option to tell it to stop when it first encounters a date outside of the range.
Replacing the custom -recentchanges might be a bit harder to do, so tackle that after you've done -yesterday, or I was planning to create it as another task. We could replace it with standard arguments "-recentchanges -ns:6", but the delay=120 means the current implementation is not fetching a lot of records from the start of the recentchanges log.
(and give it a decent module docstring)
TASK DETAIL
https://phabricator.wikimedia.org/T67192
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
Cc: pywikipedia-bugs, valhallasw, Multichill, Ricordisamoa, jayvdb, Liuxinyu970226, Daviskr
Daviskr added a comment.
Should `recentChanges` be moved as well or just `uploadedYesterday`?
Also, should `uploadedYesterday` be renamed to `UploadedYesterdayPageGenerator` or something more generic that would allow the user to specify a range?
TASK DETAIL
https://phabricator.wikimedia.org/T67192
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Daviskr
Cc: pywikipedia-bugs, valhallasw, Multichill, Ricordisamoa, jayvdb, Liuxinyu970226, Daviskr