XZise added a comment.
I don't agree that the mwpfh method is handling it more gracefully. Yes it doesn't throw an exception but simply casting it into a string and working on that isn't really what we want. I prefer the exception _regex is throwing, because if it's not a string we don't know what we can do with it and this is exactly what exceptions are supposed to do: Throw up the arms and stop working on it.
Moving it into Page seems sensible, because we don't know how templates are going to look like in Wikibase as afaik there is no similar system there.
TASK DETAIL
https://phabricator.wikimedia.org/T71664
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise
Cc: pywikipedia-bugs, XZise, jayvdb
Ricordisamoa added a comment.
This task has been assigned to me since the Bugzilla era. It is obviously a bug in Phabricator.
Note also that extract_templates_and_params_regex() has bugs that are not related to the OrderedDict thing.
TASK DETAIL
https://phabricator.wikimedia.org/T57882
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ricordisamoa
Cc: pywikipedia-bugs, Ladsgroup, Legoktm, Ricordisamoa, jayvdb, Strainu, Xqt