jayvdb closed this task as "Resolved".
jayvdb claimed this task.
jayvdb added a comment.
Specifying that tests require a valid user has been added, allowing only anon tests to be run using
nosetests -a '!user'
TASK DETAIL
https://phabricator.wikimedia.org/T58960
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, Ladsgroup, valhallasw, jayvdb
jayvdb changed the title from "welcome using missing functions" to "welcome -quick fails".
jayvdb triaged this task as "Normal" priority.
TASK DETAIL
https://phabricator.wikimedia.org/T75019
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb added a comment.
The pylint entry for _parseNewUserLogOld appears to have voodoo disappeared, so that can be ignored.
In compat, the User class does not have a member getall. The compat source code uses "userlib.getall" (a module function), which was incorrectly converted/ported into an instance method.
http://git.wikimedia.org/blob/pywikibot%2Fcompat.git/64f6f0671646506863b658…
The equivalent core functionality is Site.preloadpages, however that doesnt load user info . Core does not have a preloadusers method.
TASK DETAIL
https://phabricator.wikimedia.org/T75019
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb edited the task description.
jayvdb removed a subscriber: Unknown Object (????).
jayvdb set Security to none.
TASK DETAIL
https://phabricator.wikimedia.org/T75019
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb moved this task to WMF production issues on the pywikibot-core workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T74763
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb assigned this task to XZise.
jayvdb added a comment.
I think the critical and central aspect of this bug was solved in T75122 .
TASK DETAIL
https://phabricator.wikimedia.org/T74860
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: XZise, jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb moved this task to Ready to go on the pywikibot-core workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T75025
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb moved this task to Ready to go on the pywikibot-core workboard.
TASK DETAIL
https://phabricator.wikimedia.org/T75017
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb added a comment.
The code from compat is
```
def url2link(percentname, insite, site):
"""Convert urlname of a wiki page into interwiki link format.
'percentname' is the page title as given by Page.urlname();
'insite' specifies the target Site;
'site' is the Site on which the page is found.
"""
# Note: this is only needed if linking between wikis that use different
# encodings, so it is now largely obsolete. [CONFIRM]
percentname = percentname.replace('_', ' ')
x = url2unicode(percentname, site=site)
return unicode2html(x, insite.encoding())
```
As welcome bot only works on a single site, it does not need to use this function, and should be updated to use existing methods.
checkimages does also access Wikimedia Commons, but as far as I can see Wikimedia Commons is not related to the call to function url2link, so again I think the code should be updated.
url2link should be added to README-conversion.txt / scripts/maintenance/compat2core.py , or it would also be useful to copy the missing function url2link from compat, and mark it as deprecated, so that old compat scripts work correctly.
TASK DETAIL
https://phabricator.wikimedia.org/T75017
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb triaged this task as "Low" priority.
jayvdb added a comment.
The bug has been fixed by improved Site.sametitle() , but the underlying bug in pywikibot.Link.langlinkUnsafe still exists.
TASK DETAIL
https://phabricator.wikimedia.org/T75124
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, XZise, JAnD, jayvdb