jayvdb changed the title from "diff library problem with 2.7" to "diff library problem with 2.6 and 2.7.0".
TASK DETAIL
https://phabricator.wikimedia.org/T76276
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: Mpaa, jayvdb
Cc: pywikipedia-bugs, jayvdb, XZise
jayvdb added a blocking task: T76276: diff library problem with 2.7.
TASK DETAIL
https://phabricator.wikimedia.org/T72987
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: jayvdb
Cc: pywikipedia-bugs, jayvdb, Aklapper
gerritbot added a project: Patch-For-Review.
gerritbot added a comment.
Change 176501 had a related patch set uploaded (by XZise):
[FIX] Tests: Skip timestamp tests if month changes
[[https://gerrit.wikimedia.org/r/176501]]
#patch-for-review
TASK DETAIL
https://phabricator.wikimedia.org/T76285
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: gerritbot
Cc: pywikipedia-bugs, XZise, jayvdb
gerritbot added a project: Patch-For-Review.
gerritbot added a comment.
Change 176499 had a related patch set uploaded (by XZise):
[FIX] Diff: Support Python 2.6 and 2.7.0
[[https://gerrit.wikimedia.org/r/176499]]
#patch-for-review
TASK DETAIL
https://phabricator.wikimedia.org/T76276
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: Mpaa, gerritbot
Cc: pywikipedia-bugs, jayvdb, XZise
XZise added a subscriber: XZise.
XZise added a comment.
> wikibase_tests.TestPageMethods.test_item_templates
>
> Traceback (most recent call last):
> File "./tests/wikibase_tests.py", line 554, in test_item_templates
> self.wdp.templatesWithParams()
> File "./pywikibot/tools.py", line 647, in wrapper
> return obj(*__args, **__kw)
> File "./pywikibot/page.py", line 1288, in templatesWithParams
> templates = textlib.extract_templates_and_params(self.text)
> File "./pywikibot/textlib.py", line 973, in extract_templates_and_params
> return extract_templates_and_params_regex(text)
> File "./pywikibot/textlib.py", line 1000, in
> extract_templates_and_params_regex
> thistxt = removeDisabledParts(text)
> File "./pywikibot/textlib.py", line 327, in removeDisabledParts
> return toRemoveR.sub('', text)
> TypeError: expected string or buffer
>
> (this one is unrelated I believe.. but I thought we fixed this??)
Indeed this looks like T71664, but in this case the test is directly calling `templatesWithParams` on an `ItemPage` which itself calls `textlib.extract_templates_and_params` and T71664 just prevented that `botMayEdit` calls that `templatesWithParams`. But in theory this should happen anywhere and not just with Wikia.
A possible solution would be to override `templatesWithParams` in `ItemPage` to always return an empty list.
TASK DETAIL
https://phabricator.wikimedia.org/T75513
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: XZise
Cc: pywikipedia-bugs, jayvdb, XZise
jayvdb edited the task description.
TASK DETAIL
https://phabricator.wikimedia.org/T76276
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: Mpaa, jayvdb
Cc: pywikipedia-bugs, jayvdb
jayvdb assigned this task to Mpaa.
jayvdb added a project: pywikibot-core.
TASK DETAIL
https://phabricator.wikimedia.org/T76276
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>.
To: Mpaa, jayvdb
Cc: pywikipedia-bugs, jayvdb