Hello,
The 1.23 release of MediaWiki deprecates the ResourceLoaderGetStartupModules hook which TimedMediaHandler / MwEmbedSupport depend on. See < https://bugzilla.wikimedia.org/show_bug.cgi?id=63240%3E for details.
I'd like to accelerate the complete removal of this hook. It was created as a special kludge for MwEmbedSupport, with the expectation that it would be used only on pages which require the extension, and only until MwEmbedSupport could be refactored to be in-line with other MediaWiki extensions. Instead, MwEmbedSupport uses it to load five modules on every single page: 'jquery.triggerQueueCallback', 'Spinner', 'jquery.loadingSpinner', 'jquery.mwEmbedUtil', and 'mw.MwEmbedSupport'. (A sixth module, 'mw.MwEmbedSupport.style', is also added to every page, but by different means.)
This has been the status quo for just under three years, now: commit dc5c9fe9efa, which added "TODO look into loading this on-demand instead of all pages", was merged in June 2011.
Could the multimedia team please make this a priority? I'd recommend using the opportunity to fold MwEmbedSupport support into TimedMediaHandler. MwEmbedSupport passes itself as a generic module-loading framework, but three years in, TimedMediaHandler remains its single application.
The relevant bugs are:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55550 https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 https://bugzilla.wikimedia.org/show_bug.cgi?id=42928 https://bugzilla.wikimedia.org/show_bug.cgi?id=58082
I can't imagine it's too much fun to wade into these problems, but we need to fix this, finally. I would be happy to help.
Can this wait a few weeks? We were intending to move onto UploadWizard TMH and similar unloved projects after Media Viewer's launch to all users. We're in the middle of the launch at the moment, which is using all our team's resources and then some.
I've actually already done prep work by talking to Kaltura a couple of times about the strategy to clean up TMH (and upgrade it to the newer version of the Kaltura player) some time ago, it's on our radar, including the specific issue your describing. We just don't have the bandwidth to do this involved cleanup while we're focused on Media Viewer's launch.
On Mon, Apr 21, 2014 at 1:23 AM, Ori Livneh ori@wikimedia.org wrote:
Hello,
The 1.23 release of MediaWiki deprecates the ResourceLoaderGetStartupModules hook which TimedMediaHandler / MwEmbedSupport depend on. See < https://bugzilla.wikimedia.org/show_bug.cgi?id=63240%3E for details.
I'd like to accelerate the complete removal of this hook. It was created as a special kludge for MwEmbedSupport, with the expectation that it would be used only on pages which require the extension, and only until MwEmbedSupport could be refactored to be in-line with other MediaWiki extensions. Instead, MwEmbedSupport uses it to load five modules on every single page: 'jquery.triggerQueueCallback', 'Spinner', 'jquery.loadingSpinner', 'jquery.mwEmbedUtil', and 'mw.MwEmbedSupport'. (A sixth module, 'mw.MwEmbedSupport.style', is also added to every page, but by different means.)
This has been the status quo for just under three years, now: commit dc5c9fe9efa, which added "TODO look into loading this on-demand instead of all pages", was merged in June 2011.
Could the multimedia team please make this a priority? I'd recommend using the opportunity to fold MwEmbedSupport support into TimedMediaHandler. MwEmbedSupport passes itself as a generic module-loading framework, but three years in, TimedMediaHandler remains its single application.
The relevant bugs are:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55550 https://bugzilla.wikimedia.org/show_bug.cgi?id=58086 https://bugzilla.wikimedia.org/show_bug.cgi?id=42928 https://bugzilla.wikimedia.org/show_bug.cgi?id=58082
I can't imagine it's too much fun to wade into these problems, but we need to fix this, finally. I would be happy to help.
Multimedia mailing list Multimedia@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/multimedia
On Mon, Apr 21, 2014 at 2:31 AM, Gilles Dubuc gilles@wikimedia.org wrote:
Can this wait a few weeks? We were intending to move onto UploadWizard TMH and similar unloved projects after Media Viewer's launch to all users. We're in the middle of the launch at the moment, which is using all our team's resources and then some.
Understood. And yes, it can.
On Mon, Apr 21, 2014 at 2:31 AM, Gilles Dubuc gilles@wikimedia.org wrote:
Can this wait a few weeks? We were intending to move onto UploadWizard TMH and similar unloved projects after Media Viewer's launch to all users. We're in the middle of the launch at the moment, which is using all our team's resources and then some.
Ping!
On 6/9/14, Ori Livneh ori@wikimedia.org wrote:
On Mon, Apr 21, 2014 at 2:31 AM, Gilles Dubuc gilles@wikimedia.org wrote:
Can this wait a few weeks? We were intending to move onto UploadWizard TMH and similar unloved projects after Media Viewer's launch to all users. We're in the middle of the launch at the moment, which is using all our team's resources and then some.
Ping!
Just my personal POV: I'm not sure what discussions have been had between kultura. However its been said that there's going to be a "new video player" javascript landing in TMH at some point (When is unclear. People have told me that a patch was going to land in gerrit "any day now" back in January. Now apparently its in "Q4"). Its unclear (at least to me) what the extent of this new player is, and how much of the TMH js it will replace, but I'd personally be hesitant to start working on JS cleanup of the extension (or any major non-critical js work) if its just going to be replaced shortly.
--bawolff
On Jun 9, 2014, at 5:53 PM, Brian Wolff bawolff@gmail.com wrote:
On 6/9/14, Ori Livneh ori@wikimedia.org wrote:
On Mon, Apr 21, 2014 at 2:31 AM, Gilles Dubuc gilles@wikimedia.org wrote:
Can this wait a few weeks? We were intending to move onto UploadWizard TMH and similar unloved projects after Media Viewer's launch to all users. We're in the middle of the launch at the moment, which is using all our team's resources and then some.
Ping!
Just my personal POV: I'm not sure what discussions have been had between kultura. However its been said that there's going to be a "new video player" javascript landing in TMH at some point (When is unclear. People have told me that a patch was going to land in gerrit "any day now" back in January. Now apparently its in "Q4"). Its unclear (at least to me) what the extent of this new player is, and how much of the TMH js it will replace, but I'd personally be hesitant to start working on JS cleanup of the extension (or any major non-critical js work) if its just going to be replaced shortly.
--bawolff
The "new player” is in the same upstream location as before: https://github.com/kaltura/mwEmbed. TMH shares the player modules with the “mwEmbed” so anything inside there would potentially be shared / updated and not befit from JS refactor that was not aligned with upstream.
I agree this has not gotten the priority it needs, and has dove tailed into a much longer cycle then ideal. The momentum was hurt by the rejection of supporting interoperable video formats, and with it the potential for braoder usage along with the primary core multimedia team focus on Media Viewer.
But … Brion V's efforts on software based codecs have been pretty amazing, and the fact iOS8 will support OpenGL also give new hope for that approach.
Also bawolff has been doing some great work on the THM extension which we can be better about reviewing and merging.
—michael
I understand deferring major refactors, but using the axe is not unwarranted and might be reasonably easy and painless.
For instance, as long as we use ugly workarounds, can they be made more specific? Like, load unconditionally but only in File and Special namespaces (plus other pages with timed media? https://bugzilla.wikimedia.org/58086#c2 says it's trivial, if I understand correctly).
Nemo
On Mon, Jun 9, 2014 at 4:11 PM, Ori Livneh ori@wikimedia.org wrote:
On Mon, Apr 21, 2014 at 2:31 AM, Gilles Dubuc gilles@wikimedia.org wrote:
Can this wait a few weeks? We were intending to move onto UploadWizard TMH and similar unloved projects after Media Viewer's launch to all users. We're in the middle of the launch at the moment, which is using all our team's resources and then some.
Ping!
Uh, we are even middler in the launch now... we are tracking this issue, but had to rearrange priorities a bit due to complications with the enwiki launch of MediaViewer. (You can see our plans for the next six weeks here https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/grid?aggregate_property%5Bcolumn%5D=story+points&aggregate_property%5Brow%5D=story+points&aggregate_type%5Bcolumn%5D=sum&aggregate_type%5Brow%5D=sum&color_by=type&filters%5B%5D=%5BType%5D%5Bis%5D%5BStory%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BTech+debt%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BBug%5D&filters%5B%5D=%5BType%5D%5Bis%5D%5BScope+Increase+%28UNPLANNED%29%5D&filters%5B%5D=%5BCycle%5D%5Bis%5D%5B%28Next+cycle%29%5D&group_by%5Blane%5D=release+tree+-+epic+story&group_by%5Brow%5D=priority&lanes=534%2C533%2C532%2C531&tab=Next+cycle; this issue is #543. The idea was to progress with roughly equal velocity in the four columns, but we will be unable to do that for a week or two now.)
multimedia@lists.wikimedia.org