Thanks for the great work on the dashboard, Gergo!
I was wondering if it's possible, and if it would make sense to everyone, that we filter changesets that start with WIP or [WIP] and have a separate section at the very bottom for them?
Looking at the MultimediaViewer section of the dashboard, I find that almost half of the changesets are marked as WIP and reviewing them when they're at that stage makes sense if the author explicitly invites people to (when it's a work-in-progress, but advanced enough for review).
On 1 May 2014 03:20, Gilles Dubuc gilles@wikimedia.org wrote:
Thanks for the great work on the dashboard, Gergo!
I was wondering if it's possible, and if it would make sense to everyone, that we filter changesets that start with WIP or [WIP] and have a separate section at the very bottom for them?
Yeah; that's what we do in the VE team (search operator is "-message:WIP") and it's very helpful at focussing review, especially just before the cut.
J.
On Thu, May 1, 2014 at 1:11 PM, James Forrester jforrester@wikimedia.orgwrote:
On 1 May 2014 03:20, Gilles Dubuc gilles@wikimedia.org wrote:
Thanks for the great work on the dashboard, Gergo!
I was wondering if it's possible, and if it would make sense to everyone, that we filter changesets that start with WIP or [WIP] and have a separate section at the very bottom for them?
Yeah; that's what we do in the VE team (search operator is "-message:WIP") and it's very helpful at focussing review, especially just before the cut.
It will match anything that has a "wip" substring anywhere in its commit message, though. As far as I can see there is no way in gerrit to match only the subject line of the commit message, are the start of the line, or a whole word. That's not a big deal if you want to list those commits, but if you want to hide them and there are false positives, that could be annoying.
The OpenStack wiki mentions a WIP feature in gerrit: https://wiki.openstack.org/wiki/Gerrit_Workflow#Work_in_Progress I wonder if that is version-dependent, or something they set up locally? The label system could be abused into adding a WIP next to the existing reviewed/verified labels, and it is easy to filter for that,
On 1 May 2014 13:20, Gergo Tisza gtisza@wikimedia.org wrote:
On Thu, May 1, 2014 at 1:11 PM, James Forrester jforrester@wikimedia.orgwrote:
On 1 May 2014 03:20, Gilles Dubuc gilles@wikimedia.org wrote:
Thanks for the great work on the dashboard, Gergo!
I was wondering if it's possible, and if it would make sense to everyone, that we filter changesets that start with WIP or [WIP] and have a separate section at the very bottom for them?
Yeah; that's what we do in the VE team (search operator is "-message:WIP") and it's very helpful at focussing review, especially just before the cut.
It will match anything that has a "wip" substring anywhere in its commit message, though.
Yes.
As far as I can see there is no way in gerrit to match only the subject line of the commit message, are the start of the line, or a whole word. That's not a big deal if you want to list those commits, but if you want to hide them and there are false positives, that could be annoying.
So far in 6 months we've not run into any false positives.
J.
We just have to stay away from those words in commit messages and we'll be fine :) http://www.morewords.com/contains/wip/
On Thu, May 1, 2014 at 10:37 PM, James Forrester jforrester@wikimedia.orgwrote:
On 1 May 2014 13:20, Gergo Tisza gtisza@wikimedia.org wrote:
On Thu, May 1, 2014 at 1:11 PM, James Forrester <jforrester@wikimedia.org
wrote:
On 1 May 2014 03:20, Gilles Dubuc gilles@wikimedia.org wrote:
Thanks for the great work on the dashboard, Gergo!
I was wondering if it's possible, and if it would make sense to everyone, that we filter changesets that start with WIP or [WIP] and have a separate section at the very bottom for them?
Yeah; that's what we do in the VE team (search operator is "-message:WIP") and it's very helpful at focussing review, especially just before the cut.
It will match anything that has a "wip" substring anywhere in its commit message, though.
Yes.
As far as I can see there is no way in gerrit to match only the subject line of the commit message, are the start of the line, or a whole word. That's not a big deal if you want to list those commits, but if you want to hide them and there are false positives, that could be annoying.
So far in 6 months we've not run into any false positives.
J.
James D. Forrester Product Manager, VisualEditor Wikimedia Foundation, Inc.
jforrester@wikimedia.org | @jdforrester
Multimedia mailing list Multimedia@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/multimedia
On Thu, May 1, 2014 at 1:37 PM, James Forrester jforrester@wikimedia.orgwrote:
So far in 6 months we've not run into any false positives.
That's reassuring, thanks. Added a WIP section:
https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/MultimediaVie... https://gerrit.wikimedia.org/r/#/c/131217/
multimedia@lists.wikimedia.org