On 14-03-27 10:46 PM, Prateek Saxena wrote:
The design team recently deployed the Popups[1] extension to English Wikipedia as a Beta Feature. We are using the PageImages[2] extension to get a thumbnail with a `pithumbsize` of 300. This was initially 290, but someone on IRC - I forget who - mentioned that it would be faster if it were 300.
You and Jorm and I had discussed using 220px (which is the MediaWiki default, per https://bugzilla.wikimedia.org/show_bug.cgi?id=21117 and per https://www.mediawiki.org/wiki/Requests_for_comment/Standardized_thumbnails_... ) You mentioned this patch's comment as the reason to use 300px https://gerrit.wikimedia.org/r/#/c/109878/22/js/popup.js I mentioned a vague recollection of the Multimedia team wanting to pre-render a bunch more image sizes by default, in the future, and suggested asking them for confirmation/details on that.
Unless/until the vast majority of our images are thumbnailed at 300px, I'd recommend using 220px in Hovercards.
We are facing two problems with this approach -
- Some images are taking too long to load [3]
- Sometimes the first relevant image is not picked up [4]
Any ideas on how these bugs could be resolved would be helpful. The code for the current implementation can be found on git [5].
--prtksxna
[1] https://www.mediawiki.org/wiki/Extension:Popups [2] https://www.mediawiki.org/wiki/Extension:PageImages [3] https://bugzilla.wikimedia.org/63156 [4] https://bugzilla.wikimedia.org/63177 [5] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/abafedb99d...