On Wed, Jun 4, 2008 at 8:21 PM, Stjepan Rajko stipe@asu.edu wrote:
Yep - I'm now working on the selection of the stream (some default strategy + the ability for user to change), and am modifying&borrowing the code for the download page. Then I'll tackle the player abstraction.
OK, I got a good chunk done on this front now. I consolidated the selectPlaybackMethod + showVideoDownload functions (this was listed as a @todo) and added a showVideoSelection function which is a rip-off of showVideoDownload that allows you to choose a source. The selection code doesn't actually do anything yet (it just js_logs it). You can see the example at:
http://urbanstew.org/MediaWiki/extensions/MetavidWiki/skins/mv_embed/sample_...
The icon below the playback selection icon that looks like the download icon is the stream selection icon :-) I think I can consolidate a little bit more code there and in getThumbnailHTML.
Two questions (for now :-)):
* in ROE you use the title attribute. What should we use for <video> and for <source>? I didn't find anything in the specs. For now, I used the content of the tag (e.g. <source src="...">title here</source>) but that doesn't seem too clean.
* I have a habit of adding accessor functions to classes (e.g., see mediaSource). In JS, this is not necessary - is it useful though? Should I just stop bothering with writing accessor functions?
Some inconsistencies I noticed: HTML5 <video> uses the 'poster' attribute for what MVW uses 'thumbnail'. Also, IIRC, <video> uses 'type' attribute and MVW ROE files use 'content-type'.
great! documentation ... it does not seem to grab all the methods but maybe that can be fixed somehow:)
It only grabs documented methods / classes - I'll add docs to the existing code as I touch it. With all the verboseness, eventually we should probably provide a minified version of the script.
Found another reason why it might not be pulling in all documented methods - my perl chokes on the JSDoc script, so I had to reduce some recursion parameter. That cuts down on what the script can process. I'm now trying to get a newer version of perl to work (that hopefully won't choke on the script).
The temporarily permanent home (while the code is up in the air during the transition) for the docs is now:
http://urbanstew.org/MediaWiki/extensions/MetavidWiki/skins/mv_embed/js_docs...
Best,
Stjepan