I just rebased a few of my old patches, and I'm hoping someone will decide to review (and hopefully merge) them before they need still-another rebase.
API: * https://gerrit.wikimedia.org/r/#/c/62229/ - Fixes a fatal error in the API, waiting since May 2013. * https://gerrit.wikimedia.org/r/#/c/111954/ - Yuri had an IMO pointless objection, but in the interest of getting the thing merged... * https://gerrit.wikimedia.org/r/#/c/130093/ - Just addressed suggestions and added a fix for yet-another bug in this code.
Scribunto: * https://gerrit.wikimedia.org/r/#/c/55602/ - Last in a long series of patches that were slowly merged over the past year * https://gerrit.wikimedia.org/r/#/c/84985/ - luasandbox fix for passing a table with a __pairs function to PHP code
Thanks
I'll try to have a look today and see what I can get through.
On Tue, Jul 1, 2014 at 8:56 AM, Brad Jorsch (Anomie) bjorsch@wikimedia.org wrote:
I just rebased a few of my old patches, and I'm hoping someone will decide to review (and hopefully merge) them before they need still-another rebase.
API:
- https://gerrit.wikimedia.org/r/#/c/62229/ - Fixes a fatal error in the
API, waiting since May 2013.
- https://gerrit.wikimedia.org/r/#/c/111954/ - Yuri had an IMO pointless
objection, but in the interest of getting the thing merged...
- https://gerrit.wikimedia.org/r/#/c/130093/ - Just addressed suggestions
and added a fix for yet-another bug in this code.
Scribunto:
- https://gerrit.wikimedia.org/r/#/c/55602/ - Last in a long series of
patches that were slowly merged over the past year
- https://gerrit.wikimedia.org/r/#/c/84985/ - luasandbox fix for passing
a table with a __pairs function to PHP code
Thanks
-- Brad Jorsch (Anomie) Software Engineer Wikimedia Foundation
MediaWiki-Core mailing list MediaWiki-Core@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-core
On Tue, Jul 1, 2014 at 8:56 AM, Brad Jorsch (Anomie) bjorsch@wikimedia.org wrote:
I just rebased a few of my old patches, and I'm hoping someone will decide to review (and hopefully merge) them before they need still-another rebase.
API:
- https://gerrit.wikimedia.org/r/#/c/62229/ - Fixes a fatal error in the
API, waiting since May 2013.
{{merged}}
-Chad
Change 111945 has "To be continued" in the comments by Yuri...not sure how to interpret that. Is he planing to finish looking at it?
On Tue, Jul 1, 2014 at 8:56 AM, Brad Jorsch (Anomie) bjorsch@wikimedia.org wrote:
I just rebased a few of my old patches, and I'm hoping someone will decide to review (and hopefully merge) them before they need still-another rebase.
API:
- https://gerrit.wikimedia.org/r/#/c/62229/ - Fixes a fatal error in the
API, waiting since May 2013.
- https://gerrit.wikimedia.org/r/#/c/111954/ - Yuri had an IMO pointless
objection, but in the interest of getting the thing merged...
- https://gerrit.wikimedia.org/r/#/c/130093/ - Just addressed suggestions
and added a fix for yet-another bug in this code.
Scribunto:
- https://gerrit.wikimedia.org/r/#/c/55602/ - Last in a long series of
patches that were slowly merged over the past year
- https://gerrit.wikimedia.org/r/#/c/84985/ - luasandbox fix for passing
a table with a __pairs function to PHP code
Thanks
-- Brad Jorsch (Anomie) Software Engineer Wikimedia Foundation
MediaWiki-Core mailing list MediaWiki-Core@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-core
On Tue, Jul 1, 2014 at 3:13 PM, Aaron Schulz aschulz@wikimedia.org wrote:
Change 111945 has "To be continued" in the comments by Yuri...not sure how to interpret that. Is he planing to finish looking at it?
He probably was, but I assume he got busy with Mobile stuff and forgot about it.
mediawiki-core@lists.wikimedia.org