https://bugzilla.wikimedia.org/show_bug.cgi?id=53770
Error: You do not have permission to move this page, for the following reason: The target filename is invalid
There are some examples in the bug comments. Bawolff said this: "Taking a brief look over the code. This error appears to be coming from LocalFileMoveBatch::doDBUpdates in the case it can't update the db. However in the case of that error, its supposed to rollback the db transaction, and bail, all before touching any files on the file system..."
Help?
On Wed, May 14, 2014 at 12:09 PM, Greg Grossmeier greg@wikimedia.org wrote:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53770
Error: You do not have permission to move this page, for the following reason: The target filename is invalid
There are some examples in the bug comments. Bawolff said this: "Taking a brief look over the code. This error appears to be coming from LocalFileMoveBatch::doDBUpdates in the case it can't update the db. However in the case of that error, its supposed to rollback the db transaction, and bail, all before touching any files on the file system..."
Help?
Hi folks,
Cross-posting to the Multimedia team list, since I think we should collectively come up with a plan here. Aaron Schulz is a likely candidate to help out from the MediaWiki Core side, but we are pretty likely to need at least review help from Multimedia.
I believe Aaron already has a rather ambitious fix for this in Gerrit: https://gerrit.wikimedia.org/r/#/c/127460/
However, the change is risky, and probably means breaking more things than it fixes at first. Thoughts on next steps?
Rob
Are we certain that this change will fix that particular bug? Most of the files mentioned on that ticket contain special characters, but Aaron hasn't commented on the bug, so I don't know what reproduction/investigation path led to the conclusion that this change would fix this particular bug. Also, it would be good to know if there would be an alternative, smaller, fix to that particular issue. I.e. can we quickfix this and then take the necessary time to improve the sha-1 changeset after the bug has been fixed?
Mark, since you're our man on out-of-focus duty this week, it would be great if you can contribute by starting to write unit tests to complement that changeset: https://gerrit.wikimedia.org/r/#/c/127460/ since my review feedback feedback was that it needs some in order to have some degree of confidence that merging this won't break more things than it fixes. This should be higher priority than the most recent GWToolset changesets by Dan pending review that are about introducing new features to GWToolset, which seem to be the majority of this week's out-of-focus work so far.
On Wed, May 14, 2014 at 11:54 PM, Rob Lanphier robla@wikimedia.org wrote:
On Wed, May 14, 2014 at 12:09 PM, Greg Grossmeier greg@wikimedia.org wrote:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53770
Error: You do not have permission to move this page, for the following reason: The target filename is invalid
There are some examples in the bug comments. Bawolff said this: "Taking a brief look over the code. This error appears to be coming from LocalFileMoveBatch::doDBUpdates in the case it can't update the db. However in the case of that error, its supposed to rollback the db transaction, and bail, all before touching any files on the file system..."
Help?
Hi folks,
Cross-posting to the Multimedia team list, since I think we should collectively come up with a plan here. Aaron Schulz is a likely candidate to help out from the MediaWiki Core side, but we are pretty likely to need at least review help from Multimedia.
I believe Aaron already has a rather ambitious fix for this in Gerrit: https://gerrit.wikimedia.org/r/#/c/127460/
However, the change is risky, and probably means breaking more things than it fixes at first. Thoughts on next steps?
Rob
Multimedia mailing list Multimedia@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/multimedia
On Thu, May 15, 2014 at 5:39 AM, Gilles Dubuc gilles@wikimedia.org wrote:
Are we certain that this change will fix that particular bug?
Nope, I'm not. I'm merely guessing based on conversations I've had with Aaron about this general area of code, and a hazy understanding of what's generally going on there. The reason why I've guessed that this is the ambitious version of the fix is that storing images by SHA-1 rather than their descriptive-title-dot-filetype-extension is a step toward making it so that title renames ("page move" in MediaWiki) doesn't literally result in a file move in our backend storage.
Most of the files mentioned on that ticket contain special characters, but Aaron hasn't commented on the bug, so I don't know what reproduction/investigation path led to the conclusion that this change would fix this particular bug. Also, it would be good to know if there would be an alternative, smaller, fix to that particular issue. I.e. can we quickfix this and then take the necessary time to improve the sha-1 changeset after the bug has been fixed?
Mark, since you're our man on out-of-focus duty this week, it would be great if you can contribute by starting to write unit tests to complement that changeset: https://gerrit.wikimedia.org/r/#/c/127460/ since my review feedback feedback was that it needs some in order to have some degree of confidence that merging this won't break more things than it fixes. This should be higher priority than the most recent GWToolset changesets by Dan pending review that are about introducing new features to GWToolset, which seem to be the majority of this week's out-of-focus work so far.
Seems reasonable, thanks!
Rob
mediawiki-core@lists.wikimedia.org