I had a useful conversation about Puppet changes with Mark and Faidon. The outcome is this: the conditions under which I am allowed to merge Puppet changes are:
1) The change is my own 2) The change has been +1'd by an ops team member with sufficient domain expertise
Sometimes you guys add me as the sole reviewer of small Puppet changes. Please be aware that I am not able to merge those changes on my own, and help me out by adding some relevant opsen. Giuseppe (_joe_ on irc) is my buddy for mediawiki-related changes so he's a good person to add. Adding whomever is on RT duty is probably a good idea as well. You can still add me for initial review and +1 / -1.
Le 29/05/2014 20:53, Ori Livneh a écrit :
I had a useful conversation about Puppet changes with Mark and Faidon. The outcome is this: the conditions under which I am allowed to merge Puppet changes are:
- The change is my own
- The change has been +1'd by an ops team member with sufficient domain
expertise
Sometimes you guys add me as the sole reviewer of small Puppet changes. Please be aware that I am not able to merge those changes on my own, and help me out by adding some relevant opsen. Giuseppe (_joe_ on irc) is my buddy for mediawiki-related changes so he's a good person to add. Adding whomever is on RT duty is probably a good idea as well. You can still add me for initial review and +1 / -1.
Hello Ori,
That sounds reasonable.
Since I am mostly interacting with Europe based ops, I have added a group in Gerrit that let me add them all easily: ops-europe-based
https://gerrit.wikimedia.org/r/#/admin/groups/629,members
Valhallasw wrote a bot that adds reviewers based on a list. It is using wikitext to define people to be added:
https://www.mediawiki.org/wiki/Git/Reviewers
Maybe we can work with ops to add them to that list. Our team can probably use something similar.
mediawiki-core@lists.wikimedia.org