Anyone in Discovery have the cycles to look at the Swift plugin I wrote?
-Chad ---------- Forwarded message ---------- From: "Avik Das" avdas@syr.edu Date: May 11, 2016 11:58 PM Subject: Request for code review and merge for wikimedia/search-repository-swift To: "chadh@wikimedia.org" chadh@wikimedia.org Cc:
Hi,
I was working on elasticsearch plugins and was looking for snapshot plugins. Recently, I came across your repository and found it very useful and generic. However I needed plugin for elasticsearch version 2.1.1. I forked from the main branch and created some changes in my local repository. I am writing this email to request for code review and for merging into main branch for elasticsearch 2.1.1 . I tested my plugin on my local machine and swift repository from Soft Layer Object storage. Please let me know if you need any more information or action from my side.
Please find the link for my repository below https://github.com/avik1988/search-repository-swift.git https://github.com/avik1988/search-repository-swift.git avik1988/search-repository-swift https://github.com/avik1988/search-repository-swift.git github.com search-repository-swift - Github mirror of "search/repository-swift" - our actual code is hosted with Gerrit (please see https://www.mediawiki.org/wiki/Developer_access for contributing
Thanks,
Avik Das
Sure, I'll have a look maybe tomorrow. What's the best way for him to contribute? I suppose that we can't work with github, I think we could maybe ask him to submit a patch over gerrit? Or maybe I can just apply his patch but he'll lose ownership :/
Thanks!
Le 12/05/2016 17:19, Chad Horohoe a écrit :
Anyone in Discovery have the cycles to look at the Swift plugin I wrote?
-Chad
---------- Forwarded message ---------- From: "Avik Das" <avdas@syr.edu mailto:avdas@syr.edu> Date: May 11, 2016 11:58 PM Subject: Request for code review and merge for wikimedia/search-repository-swift To: "chadh@wikimedia.org mailto:chadh@wikimedia.org" <chadh@wikimedia.org mailto:chadh@wikimedia.org> Cc:
Hi,
I was working on elasticsearch plugins and was looking for snapshot plugins. Recently, I came across your repository and found it very useful and generic. However I needed plugin for elasticsearch version 2.1.1. I forked from the main branch and created some changes in my local repository. I am writing this email to request for code review and for merging into main branch for elasticsearch 2.1.1 . I tested my plugin on my local machine and swift repository from Soft Layer Object storage. Please let me know if you need any more information or action from my side.
Please find the link for my repository below https://github.com/avik1988/search-repository-swift.git
https://github.com/avik1988/search-repository-swift.git
avik1988/search-repository-swift https://github.com/avik1988/search-repository-swift.git github.com http://github.com search-repository-swift - Github mirror of "search/repository-swift" - our actual code is hosted with Gerrit (please see https://www.mediawiki.org/wiki/Developer_access for contributing
Thanks,
Avik Das
discovery mailing list discovery@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/discovery
I don't see why we couldn't do the review on Github. Can always preserve the authorship (if not committership) when landing on Gerrit.
-Chad
On Thu, May 12, 2016 at 8:41 AM, David Causse dcausse@wikimedia.org wrote:
Sure, I'll have a look maybe tomorrow. What's the best way for him to contribute? I suppose that we can't work with github, I think we could maybe ask him to submit a patch over gerrit? Or maybe I can just apply his patch but he'll lose ownership :/
Thanks!
Le 12/05/2016 17:19, Chad Horohoe a écrit :
Anyone in Discovery have the cycles to look at the Swift plugin I wrote?
-Chad ---------- Forwarded message ---------- From: "Avik Das" avdas@syr.edu Date: May 11, 2016 11:58 PM Subject: Request for code review and merge for wikimedia/search-repository-swift To: "chadh@wikimedia.org" chadh@wikimedia.org Cc:
Hi,
I was working on elasticsearch plugins and was looking for snapshot plugins. Recently, I came across your repository and found it very useful and generic. However I needed plugin for elasticsearch version 2.1.1. I forked from the main branch and created some changes in my local repository. I am writing this email to request for code review and for merging into main branch for elasticsearch 2.1.1 . I tested my plugin on my local machine and swift repository from Soft Layer Object storage. Please let me know if you need any more information or action from my side.
Please find the link for my repository below https://github.com/avik1988/search-repository-swift.git https://github.com/avik1988/search-repository-swift.git avik1988/search-repository-swift https://github.com/avik1988/search-repository-swift.git github.com search-repository-swift - Github mirror of "search/repository-swift" - our actual code is hosted with Gerrit (please see https://www.mediawiki.org/wiki/Developer_access for contributing
Thanks,
Avik Das
discovery mailing listdiscovery@lists.wikimedia.orghttps://lists.wikimedia.org/mailman/listinfo/discovery
discovery mailing list discovery@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/discovery
Hi!
Sure, I'll have a look maybe tomorrow. What's the best way for him to contribute? I suppose that we can't work with github, I think we could maybe ask him to submit a patch over gerrit? Or maybe I can just apply his patch but he'll lose ownership :/
You can cherry-pick patch from github branch and commit it to gerrit. E.g. see this as an example: https://github.com/wikimedia/wikidata-query-rdf/commit/eb9f6f37cfc2cc9ea2da0...
With git, author and committer do not have to be the same and while gerrit seems to limit committers on some repos, authors are fine.