Le 02/04/13 04:39, MZMcBride a écrit :
I'm concerned that Gerrit actively discourages
discussion currently.
So do not use it? We have lists, wiki and private emails.
I see a few issues:
* auto-collapsing all comments except the most recent;
* no reply feature or support for quoting (similar to what Bugzilla uses);
and
* the "add comment" feature doesn't allow you to write a comment while
viewing the code or viewing the other comments, resulting in an awful
workflow for me when attempting to write a comment.
The basic misconception is that people attempt to comment the code using
the 'cover message' feature when they should really use the inline
commenting feature. The cover message is only intended to summarize
what you have commented inline, that is also what is shown in the mail
notification.
When doing inline comments, they are shown in the diff. So if one
commented on patchset 2 and is willing to find out whether his
suggestion has been achieved, he could use the PS2 as a basis for a
diff. All his comments will be shown as well as the following up changes.
When I amend a patchset, I will use the [Done] button on each change to
confirm the reviewers that I have corrected the issues.
Is there some way to address these issues? Would it
make sense to move all
discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior
here? Or perhaps I'm the only one who finds this problematic.
I would prefer having all the code and implementations discussion where
the code is, aka in Gerrit. Leaving Bugzilla for confirming the bug
resolution or talk about possible policy issues.
--
Antoine "hashar" Musso