Gerrit actively discourages discussion

List overview All Threads
Download

newer

older

GSoC: accepted! Mentors: apply,...

MediaWiki 1.21rc2 -- More 1.21...

MZMcBride

2 Apr 2013 2 Apr '13

3:39 a.m.

Hi. I'm concerned that Gerrit actively discourages discussion currently. I see a few issues: * auto-collapsing all comments except the most recent; * no reply feature or support for quoting (similar to what Bugzilla uses); and * the "add comment" feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment. Is there some way to address these issues? Would it make sense to move all discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior here? Or perhaps I'm the only one who finds this problematic. MZMcBride

Show replies by date

Matthew Walker

2 Apr 2 Apr

3:51 a.m.

You are definitely not the only one who finds these issues annoying. I too worry about the same. ~Matt Walker Wikimedia Foundation Fundraising Technology Team On Mon, Apr 1, 2013 at 7:39 PM, MZMcBride <z(a)mzmcbride.com> wrote:

...

Jeremy Baron

4:31 a.m.

On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker <mwalker(a)wikimedia.org> wrote:

...

You are definitely not the only one who finds these issues annoying. I too worry about the same.

Brian Wolff

6:43 a.m.

On 2013-04-02 12:32 AM, "Jeremy Baron" <jeremy(a)tuxmachine.com> wrote:

...

On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker <mwalker(a)wikimedia.org>

wrote:

...

> You are definitely not the only one who finds these issues annoying. I

too

...

worry about the same.

+1 Another big one is "(1 comment)" which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever). OTOH, the email notifs about inline code comments are often useful. -Jeremy _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

+1 to both emails. It can be very frustrating trying to follow a conversation on gerrit after the fact. -bawolff

Isarra Yos

6:48 a.m.

On 02/04/13 06:43, Brian Wolff wrote:

...

On 2013-04-02 12:32 AM, "Jeremy Baron" <jeremy(a)tuxmachine.com> wrote:

On Tue, Apr 2, 2013 at 2:51 AM, Matthew Walker <mwalker(a)wikimedia.org>

wrote:

> You are definitely not the only one who finds these issues annoying. I

too

worry about the same.

+1 to both emails. It can be very frustrating trying to follow a conversation on gerrit after the fact. -bawolff _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

This is especially true when considering the results of submitting a new patchset - it can cause all old comments to get lost, in a sense - inline ones are hidden in the previous patchset (which is collapsed), and a new comment covers previous comments, obfuscating any current discussion. -- -— Isarra

S Page

9 Apr 9 Apr

12:32 a.m.

On Mon, Apr 1, 2013 at 8:31 PM, Jeremy Baron <jeremy(a)tuxmachine.com> wrote:

...

Another big one is "(1 comment)" which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever).

This one drives me crazy, especially after I've responded to existing comments on Patch Set N. When someone new comments on the same patch set, how can I find the new comments? The best I can do is visit every file in the patch set that has comments and Ctrl+F/Ctrl+G to search for the new reviewer's name. It's already filed as https://bugzilla.wikimedia.org/show_bug.cgi?id=46792 -- =S Page software engineer on E3

Chad

12:46 a.m.

On Mon, Apr 8, 2013 at 7:32 PM, S Page <spage(a)wikimedia.org> wrote:

...

On Mon, Apr 1, 2013 at 8:31 PM, Jeremy Baron <jeremy(a)tuxmachine.com> wrote:

Another big one is "(1 comment)" which gives no information about the comment or where it was made and no easy way to jump straight to it. (a link or AJAX or whatever).

This used to work, but the output format changed a couple of upgrades ago. The hook scripts for Gerrit are all in the puppet repo if anyone cares to hack at them. -Chad

Jon Robson

2 Apr 2 Apr

7:34 a.m.

Thanks for bringing this up MZ. I completely agree with you. The amount of times I've had to link people on irc to a comment to see it is ridiculous. I'm not sure what the exact solution is but I feel we need to improve it in gerrit itself rather than move to bugzilla. On Mon, Apr 1, 2013 at 7:39 PM, MZMcBride <z(a)mzmcbride.com> wrote:

...

-- Jon Robson http://jonrobson.me.uk @rakugojon

Antoine Musso

8:46 a.m.

Le 02/04/13 04:39, MZMcBride a écrit :

...

I'm concerned that Gerrit actively discourages discussion currently.

So do not use it? We have lists, wiki and private emails.

...

I see a few issues: * auto-collapsing all comments except the most recent; * no reply feature or support for quoting (similar to what Bugzilla uses); and * the "add comment" feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment.

The basic misconception is that people attempt to comment the code using the 'cover message' feature when they should really use the inline commenting feature. The cover message is only intended to summarize what you have commented inline, that is also what is shown in the mail notification. When doing inline comments, they are shown in the diff. So if one commented on patchset 2 and is willing to find out whether his suggestion has been achieved, he could use the PS2 as a basis for a diff. All his comments will be shown as well as the following up changes. When I amend a patchset, I will use the [Done] button on each change to confirm the reviewers that I have corrected the issues.

...

Is there some way to address these issues? Would it make sense to move all discussion back to Bugzilla? Is there some way to adjust Gerrit's behavior here? Or perhaps I'm the only one who finds this problematic.

I would prefer having all the code and implementations discussion where the code is, aka in Gerrit. Leaving Bugzilla for confirming the bug resolution or talk about possible policy issues. -- Antoine "hashar" Musso

K. Peachey

9 a.m.

On Tue, Apr 2, 2013 at 5:46 PM, Antoine Musso <hashar+wmf(a)free.fr> wrote:

...

Le 02/04/13 04:39, MZMcBride a écrit :

I'm concerned that Gerrit actively discourages discussion currently.

So do not use it? We have lists, wiki and private emails.

Private email would be even worse... I'm surprised you even thought to consider it.

MZMcBride

2:03 p.m.

Antoine Musso wrote:

...

Le 02/04/13 04:39, MZMcBride a écrit :

I'm concerned that Gerrit actively discourages discussion currently.

So do not use it? We have lists, wiki and private emails. [...] I would prefer having all the code and implementations discussion where the code is, aka in Gerrit. Leaving Bugzilla for confirming the bug resolution or talk about possible policy issues.

You're being a little silly here. :-) I think I agree with you that keeping the change and the related discussion together would be nice. The question is: how do we make Gerrit less painful to use? Would it be possible to have Gerrit import a JavaScript page from MediaWiki.org (e.g., "MediaWiki:Gerrit.js")? This might allow dedicated users to override some of the default behavior (such as the block-level comment auto-collapsing) or add new functionality (such as a "reply" link similar to Bugzilla's).

...

Gerrit supports both inline commenting and block-level commenting. The inline commenting is actually even more difficult to find and follow than block-level commenting, in my opinion. MZMcBride

Chad

2:10 p.m.

On Tue, Apr 2, 2013 at 9:03 AM, MZMcBride <z(a)mzmcbride.com> wrote:

...

Would it be possible to have Gerrit import a JavaScript page from MediaWiki.org (e.g., "MediaWiki:Gerrit.js")? This might allow dedicated users to override some of the default behavior (such as the block-level comment auto-collapsing) or add new functionality (such as a "reply" link similar to Bugzilla's).

Luke Welling WMF

3:57 p.m.

For my own changes I have a workflow that's a little clunky, but works for me. I'll comment or mark done on every comment, so if I see the same number of drafts as comments, I know I've addressed them all. The workflow I have not found is a way to efficiently re-review other people's changes that I've previously reviewed. It takes a lot of time to properly review a big change, and I don't know an easy way to say "Show me all my comments on previous patch sets so I can see if they have been addressed". Luke Welling On Tue, Apr 2, 2013 at 9:10 AM, Chad <innocentkiller(a)gmail.com> wrote:

...

On Tue, Apr 2, 2013 at 9:03 AM, MZMcBride <z(a)mzmcbride.com> wrote:

There's functionality to write custom Javascript and inject it within Gerrit. So yes, we could easily have our own JS that overrides default behavior here. I wouldn't feel entirely comfortable fetching it from MediaWiki.org on the fly--but we can host the code within Gerrit. -Chad _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Christian Aistleitner

9:55 a.m.

Hi, while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions. On Mon, Apr 01, 2013 at 10:39:50PM -0400, MZMcBride wrote:

...

* auto-collapsing all comments except the most recent;

https://bugzilla.wikimedia.org/show_bug.cgi?id=46774

...

* no reply feature or support for quoting (similar to what Bugzilla uses);

https://bugzilla.wikimedia.org/show_bug.cgi?id=46776

...

* the "add comment" feature doesn't allow you to write a comment while viewing the code or viewing the other comments, resulting in an awful workflow for me when attempting to write a comment.

https://bugzilla.wikimedia.org/show_bug.cgi?id=46777 Best regards, Christian -- ---- quelltextlich e.U. ---- \\ ---- Christian Aistleitner ---- Companies' registry: 360296y in Linz Christian Aistleitner Gruendbergstrasze 65a Email: christian(a)quelltextlich.at 4040 Linz, Austria Phone: +43 732 / 26 95 63 Fax: +43 732 / 26 95 63 Homepage: http://quelltextlich.at/ ---------------------------------------------------------------

MZMcBride

3 Apr 3 Apr

3:54 a.m.

Christian Aistleitner wrote:

...

while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions.

This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride

Jon Robson

6:14 a.m.

I feel very dirty having done this but I made a chrome extension that autoexpands all comments and adds a comment count next to unexpanded older patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride <z(a)mzmcbride.com> wrote:

...

Christian Aistleitner wrote:

while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions.

This is wonderful. Thank you for filing these bugs, Christian. I'll take a look at them now. MZMcBride _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

-- Jon Robson http://jonrobson.me.uk @rakugojon

Yuri Astrakhan

6:53 a.m.

This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson <jdlrobson(a)gmail.com> wrote:

...

Christian Aistleitner wrote:

while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions.

This is wonderful. Thank you for filing these bugs, Christian. I'll take

look at them now. MZMcBride _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

-- Jon Robson http://jonrobson.me.uk @rakugojon _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Yuri Astrakhan

6:55 p.m.

Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation fails, its ok to click to expand just that comment. Or maybe just expand the last jenkin-bot comment, but hide all the previous ones. On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan <yastrakhan(a)wikimedia.org>wrote;wrote:

...

This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson <jdlrobson(a)gmail.com> wrote:

Christian Aistleitner wrote:

while I do not want to discourage discussion of those items on wikitech-l, I nevertheless filed them in bugzilla, so we can keep track of the issues / solutions.

This is wonderful. Thank you for filing these bugs, Christian. I'll

take a

look at them now. MZMcBride _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Jon Robson

7:49 p.m.

Yuri Great minds think alike ;-) https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b5… On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan <yastrakhan(a)wikimedia.org>wrote;wrote:

...

wrote:

This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too scared :) On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson <jdlrobson(a)gmail.com> wrote: > I feel very dirty having done this but I made a chrome extension that > autoexpands all comments and adds a comment count next to unexpanded

older

patchsets. The code's horrible but it works - feel free to try it out: https://github.com/jdlrobson/gerrit-be-nice-to-me I suspect the best long term solution might be to rewrite the interface. The fact it is so ajaxay makes enhancements hard unless someone actually wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride <z(a)mzmcbride.com> wrote:

Christian Aistleitner wrote: >while I do not want to discourage discussion of those items on >wikitech-l, I nevertheless filed them in bugzilla, so we can keep >track of the issues / solutions. This is wonderful. Thank you for filing these bugs, Christian. I'll

take a

look at them now. MZMcBride _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

-- Jon Robson http://jonrobson.me.uk @rakugojon

Yuri Astrakhan

8:17 p.m.

hehe, thanks! :), just pulled again, but, its broken a bit :( https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it deleted comment lines, but apparently its just in indecipherable colors, until clicked On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson <jdlrobson(a)gmail.com> wrote:

...

Yuri Great minds think alike ;-) https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b5… On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan <yastrakhan(a)wikimedia.org

wrote:

Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation

fails,

its ok to click to expand just that comment. Or maybe just expand the

last > jenkin-bot comment, but hide all the previous ones. > > > On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan <yastrakhan(a)wikimedia.org >

wrote:

> > > This is awesome!!! Thanks Jon :) And no, I didn't look at the code, too > > scared :) > > > > > > On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson <jdlrobson(a)gmail.com> wrote:

> I feel very dirty having done this but I made a chrome extension that > autoexpands all comments and adds a comment count next to unexpanded

older >> patchsets. >> >> The code's horrible but it works - feel free to try it out: >> >> https://github.com/jdlrobson/gerrit-be-nice-to-me >> >> I suspect the best long term solution might be to rewrite the

interface.

>> The fact it is so ajaxay makes enhancements hard unless someone

actually

wants to get to know and work on the gerrit codebase themselves... On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride <z(a)mzmcbride.com> wrote: > Christian Aistleitner wrote: > >while I do not want to discourage discussion of those items on > >wikitech-l, I nevertheless filed them in bugzilla, so we can keep > >track of the issues / solutions. > > This is wonderful. Thank you for filing these bugs, Christian. I'll take a > look at them now. > > MZMcBride > > > > _______________________________________________ > Wikitech-l mailing list > Wikitech-l(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > -- Jon Robson http://jonrobson.me.uk @rakugojon _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Jon Robson

8:19 p.m.

You'll need to reload the extension in chrome://extensions It purposely doesn't delete the comment lines - it just makes them invisible just in case you might want to see them. It's all one big hack so might be wrong but it works for me ;-) On Wed, Apr 3, 2013 at 12:17 PM, Yuri Astrakhan <yastrakhan(a)wikimedia.org>wrote;wrote:

...

Yuri Great minds think alike ;-)

https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b5…

On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan <

yastrakhan(a)wikimedia.org

wrote:

Jon, do you think it might make sense to hide all those jenkin-bot comments? They are mostly noise, and the only time when compilation

fails,

its ok to click to expand just that comment. Or maybe just expand the

last > jenkin-bot comment, but hide all the previous ones. > > > On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan <

yastrakhan(a)wikimedia.org

> >wrote: > > > This is awesome!!! Thanks Jon :) And no, I didn't look at the code,

too

> scared :) > > > On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson <jdlrobson(a)gmail.com>

wrote: > > > >> I feel very dirty having done this but I made a chrome extension

that

> autoexpands all comments and adds a comment count next to unexpanded

interface.

>> The fact it is so ajaxay makes enhancements hard unless someone

actually > >> wants to get to know and work on the gerrit codebase themselves... > >> > >> > >> On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride <z(a)mzmcbride.com> wrote: > >> > >> > Christian Aistleitner wrote: > >> > >while I do not want to discourage discussion of those items on > >> > >wikitech-l, I nevertheless filed them in bugzilla, so we can keep > >> > >track of the issues / solutions. > >> > > >> > This is wonderful. Thank you for filing these bugs, Christian.

I'll

> take a > > look at them now. > > > > MZMcBride > > > > > > > > _______________________________________________ > > Wikitech-l mailing list > > Wikitech-l(a)lists.wikimedia.org > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > > > > > > -- > Jon Robson > http://jonrobson.me.uk > @rakugojon > _______________________________________________ > Wikitech-l mailing list > Wikitech-l(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l >

_______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

-- Jon Robson http://jonrobson.me.uk @rakugojon

Yuri Astrakhan

8:45 p.m.

on both monitors i checked, 0.2 opacity is too low, plus I don't think it should apply to the border, just the header inside it, which also removes the need to restore it on click. What do you think? function silentNoise( $commentPanel ) { // makes jenkins comments less prominent $commentPanel.find( '.commentPanelHeader' ).css( 'opacity', 0.6 ); } On Wed, Apr 3, 2013 at 3:19 PM, Jon Robson <jdlrobson(a)gmail.com> wrote:

...

wrote:

hehe, thanks! :), just pulled again, but, its broken a bit :( https://gerrit.wikimedia.org/r/#/c/53131/ -- at first i thought it

deleted

comment lines, but apparently its just in indecipherable colors, until clicked On Wed, Apr 3, 2013 at 2:49 PM, Jon Robson <jdlrobson(a)gmail.com> wrote:

Yuri Great minds think alike ;-)

https://github.com/jdlrobson/gerrit-be-nice-to-me/commit/d6fd7913ff8fd7b1b5… > > > > > > On Wed, Apr 3, 2013 at 10:55 AM, Yuri Astrakhan < > yastrakhan(a)wikimedia.org > >

wrote:

> > > > > Jon, do you think it might make sense to hide all those jenkin-bot > > > comments? They are mostly noise, and the only time when compilation > > fails, > > > its ok to click to expand just that comment. Or maybe just expand the > > last > > > jenkin-bot comment, but hide all the previous ones. > > > > > > > > > On Wed, Apr 3, 2013 at 1:53 AM, Yuri Astrakhan < > yastrakhan(a)wikimedia.org > > >

wrote:

> > > > > > > This is awesome!!! Thanks Jon :) And no, I didn't look at the code, > too > > > > scared :) > > > > > > > > > > > > On Wed, Apr 3, 2013 at 1:14 AM, Jon Robson <jdlrobson(a)gmail.com> > > wrote: > > > > > > > >> I feel very dirty having done this but I made a chrome extension > that > > > >> autoexpands all comments and adds a comment count next to unexpanded

> > older > > >> patchsets. > > >> > > >> The code's horrible but it works - feel free to try it out: > > >> > > >> https://github.com/jdlrobson/gerrit-be-nice-to-me > > >> > > >> I suspect the best long term solution might be to rewrite the > interface. > > >> The fact it is so ajaxay makes enhancements hard unless someone > actually > > >> wants to get to know and work on the gerrit codebase themselves... > > >> > > >> > > >> On Tue, Apr 2, 2013 at 7:54 PM, MZMcBride <z(a)mzmcbride.com>

wrote:

> > >> > > >> > Christian Aistleitner wrote: > > >> > >while I do not want to discourage discussion of those items on > > >> > >wikitech-l, I nevertheless filed them in bugzilla, so we can

keep

> >> > >track of the issues / solutions. > >> > > >> > This is wonderful. Thank you for filing these bugs, Christian.

I'll

>> take a >> > look at them now. >> > >> > MZMcBride >> > >> > >> > >> > _______________________________________________ >> > Wikitech-l mailing list >> > Wikitech-l(a)lists.wikimedia.org >> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l >> > >> >> >> >> -- >> Jon Robson >> http://jonrobson.me.uk >> @rakugojon >> _______________________________________________ >> Wikitech-l mailing list >> Wikitech-l(a)lists.wikimedia.org >> https://lists.wikimedia.org/mailman/listinfo/wikitech-l >> > > _______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_______________________________________________ Wikitech-l mailing list Wikitech-l(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

4047

days inactive

4053

days old

wikitech-l@lists.wikimedia.org

Manage subscription

21 comments

13 participants

tags (0)

participants (13)

Antoine Musso
Brian Wolff
Chad
Christian Aistleitner
Isarra Yos
Jeremy Baron
Jon Robson
K. Peachey
Luke Welling WMF
Matthew Walker
MZMcBride
S Page
Yuri Astrakhan