Daniel Friesen wrote:
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80248
Comment gives a Tesla link saying something broke. However the Tesla
link does not identify that commit as the guaranteed commit that
actually broke code. The commit was followed up with several fixmes
already and it's unknown if the breakage is still present. The commit is
potentially perfectly functional, hit by Tesla catching a completely
unrelated commit, or marking a bug that's already fixed.
Come on. It is easy enough to check if your revision is the culprit.
svn up -r r80247
cd tests/phpunit/
make noparser
There was 1 failure:
1) NewParserTest::testParserTests
Bad images - basic functionality (failed: Bad images - basic functionality
There were 9 incomplete tests:
1) ApiUploadTest::testUpload
RandomImageGenerator: dictionary file not found or not specified properly
2) ApiUploadTest::testUploadSameFileName
RandomImageGenerator: dictionary file not found or not specified properly
3) ApiUploadTest::testUploadSameContent
RandomImageGenerator: dictionary file not found or not specified properly
4) ApiUploadTest::testUploadStash
RandomImageGenerator: dictionary file not found or not specified properly
5) ApiTest::testApiGotCookie
The server can't do external HTTP requests, and the internal one won't
give cookies
6) ApiWatchTest::testWatchEdit
Broken
7) ApiWatchTest::testWatchProtect
Broken
8) ApiWatchTest::testWatchRollback
Only one author to 'UTPage', cannot test rollback
9) ApiWatchTest::testWatchDelete
Broken
There were 2 skipped tests:
1) ApiTest::testApiListPages
This test depends on "ApiTest::testApiGotCookie" to pass.
2) ApiWatchTest::testWatchClear
This test depends on "ApiWatchTest::testWatchEdit" to pass.
cd ../..
svn up -r r80248
cd tests/phpunit/
make noparser
There were 2 errors:
1) ApiBlockTest::testMakeNormalBlock
htmlspecialchars() expects parameter 1 to be string, object given
2) NewParserTest::testFuzzTests
MWException: Out of memory:
--
There were 3 failures:
1) TitlePermissionTest::testQuickPermissions
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array
(
[0] => Array
(
[0] => badaccess-groups
- [1] => *, [[Local:Users|Users]]
+ [1] => *, Users
[2] => 2
)
)
2) TitlePermissionTest::testPageRestrictions
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array
(
[0] => Array
(
[0] => badaccess-groups
- [1] => *, [[Local:Users|Users]]
+ [1] => *, Users
[2] => 2
)
[1] => Array
(
[0] => protectedpagetext
[1] => bogus
)
[2] => Array
(
[0] => protectedpagetext
[1] => protect
)
[3] => Array
(
[0] => protectedpagetext
[1] => protect
)
)
3) NewParserTest::testParserTests
Bad images - basic functionality (failed: Bad images - basic functionality
Failed asserting that <text> is equal to <string:>.
Bad images - basic functionality)
Failed asserting that <boolean:false> is true.
So r80248 did break three tests.
cd ../..
svn up
cd tests/phpunit
php phpunit.php includes/api/ApiBlockTest.php
OK (1 test, 4 assertions)
php phpunit.php includes/TitlePermissionTest.php
There was 1 failure:
1) TitlePermissionTest::testUserBlock
Failed asserting that two arrays are equal.
This is a different test, which expects infinite and now returns a
Message Object.
The problem was fixed in trunk.