Le 15/01/13 12:44, Jeroen De Dauw wrote:
I have observed a difference in opinion between two groups of people on
gerrit, which unfortunately is causing bad blood on both sides. I'm
therefore interested in hearing your opinion about the following scenario:
Someone makes a sound commit. The commit has a clear commit message, though
there is a single typo in it. Is it helpful to -1 the commit because of the
typo?
Yup -1 anything that is wrong, even if it is the must trivial error ever
encountered. We have a pre commit review workflow exactly for that.
If you feel brave enough, you could edit it yourself:
- download the change
- amend it
- sent patchset back
- leave a message (fixed typo)
- removed yourself from the reviewer list
Done :-]
I wanted to have a spell checker to lint the commit message, but
eventually gave up because of the number of false positives.
--
Antoine "hashar" Musso