Simetrical schrieb:
On Wed, Mar 5, 2008 at 10:44 AM,
<raymond-Y8jq7F6rJ48dvk2hry9Ukdi2O/JbrIOy(a)public.gmane.org> wrote:
+ # Look for 'special:' in
the line
+ $pos = strpos( $line, 'special:' );
Eek, case-sensitive?
Fixed with r31591.
+ $canonical = strtolower(
trim( substr( $line, $pos + 8 ) ) );
Don't use magic numbers. $pos + strlen( 'special:' ) is more
comprehensible.
Fixed with r31591 too. Thanks :)
+
return '<p style="float:' . $align . ';"
class="mw-specialspecialpages-edit">' . $link . '</p>';
Why not put the float style in the class definition?
You mean by adding this class to main.css?
. . .
If you're going to use messages, wouldn't it be better to have a
single cross-language message for this, and have the titles be indexes
into other messages the way Sidebar does it? Like
== specialpages-generalpagelists ==
:special:Allpages
...
On the other hand, is there any real downside to
hardcoding the categories and orderings, having a fixed set of
categories and allowing each special page to insert itself into the
category it likes best? Does anyone really need this extra
flexibility?
The intention was to give this extra flexibility. You can use multiple
columns now and sort in any manner the community finds it useful.
But I will think about/work on your suggestion to use messagekeys
instead to avoid duplication of the special pages list.
Raymond.