Oops! In removing spurious bands from the patch, I
accidentally
messed it up. Here is the correct version.
http://wikixp.org/lqt-changes-to-trunk-as-of-r26530-fixed.txt
Cool, thank you, it applied cleanly. No regressions on parserTests, and just one E_STRICT
warning on fuzz tests:
Strict Standards: Only variables should be passed by reference in includes/EditPage.php on
line 1449
Backtrace:
EditPage.getPreviewText() # line 1059, file: includes/EditPage.php
EditPage.showEditForm() # line 438, file: includes/EditPage.php
EditPage.edit() # line 290, file: includes/EditPage.php
EditPage.submit() # line 442, file: includes/Wiki.php
MediaWiki.performAction(Object:OutputPage, Object:Article, Object:Title, Object:User,
Object:WebRequest) # line 48, file:
includes/Wiki.php
MediaWiki.initialize(Object:Title, Object:OutputPage, Object:User, Object:WebRequest) #
line 89, file: index.php
I.e. due to this line, where $wgTitle has been replaced by
$this->mArticle->getTitle() :
$parserOutput = $wgParser->parse( $this->mArticle->preSaveTransform( $toparse
) ."\n\n",
$this->mArticle->getTitle(), $parserOptions );
So I'm presuming that in includes/Parser.php, that the pass-by-ref in this function
declaration is a throwback from PHP4, and can be
removed:
- public function parse( $text, &$title, $options, $linestart = true, $clearState =
true, $revid = null ) {
+ public function parse( $text, $title, $options, $linestart = true, $clearState = true,
$revid = null ) {
... and that stops the E_STRICT warnings. No other warnings / notices were observed.
-- All the best,
Nick.