Am 17.10.2014 04:45, schrieb Jeroen De Dauw:
Hey,
I just noticed this commit [0], which gets rid of a pile of direct
BasicEntityIdParser usages for performance reasons.
Yay, thanks Katie!
Of course this also means that no new code that
introduces such occurrences
should be allowed through review, even if it contains a "fix this later" TODO
(for new code there is no excuse to do it wrong).
There's no excuse to do it wrong, but there will always be things left to do
later. TODOs are a good thing, it's just bad to put them in and forget about
them (which I'm quite guilty of, I know).
-- daniel
--
Daniel Kinzler
Senior Software Developer
Wikimedia Deutschland
Gesellschaft zur Förderung Freien Wissens e.V.