Hello,
2009/11/16 Marcin Cieslak <saper(a)saper.info>fo>:
Dnia 15.11.2009 Nakor <nakor.wp(a)gmail.com>
napisał/a:
--===============2429419130569035772==
Please test your stuff decently before you commit
it! About every time I
do an svn update I have to get rid of dozens of bugs
Maarten
I agree with Marteen. Maybe a branch system should be implemented to
garantee trunk stability.
Maybe committer in question could comment on what (s)he is doing?
It's not the first time. Branches are not necessary, one is free to experiment
in his/her local archive.
The committer in question never comments on what he's doing.
We could of course switch to Mercurial if we really
need per-developer branches.
I could not agree more here. Mercurial has a lot of very interesting features.
However, if we adopt a "push-all" model, the kind of problems we're
experimenting will not go away, as every committer will still be able
to break the mainline when pushing his changes. Changing the tool
alone does not fix bad development habits.
The only way to ensure stability IMHO is to introduce a strict review
process, where a changeset has to be reviewed by a qualified developer
other than the submitter before making it into the main development
branch. It appears to slow down the process at first, because it
introduces a delay in the commit workflow, but in the end code
quality significantly improves, and this reduces maintenance costs.
Being now used to the Mercurial community, where each patch is sent to
the dev- mailing list before being pulled by the relevant maintainer,
I would love to see those practices here. If the community was
interested to do the switch, I would be willing to spend a significant
part of my time to review patches, and/or give assistance in Mercurial
usage. I think that a few developers in the past got tired of
pywikipedia, specifically because of our development process. I would
love to improve that aspect of our project.
Regards,
--
<< Marcin Cieslak // saper(a)saper.info >>
_______________________________________________
Pywikipedia-l mailing list
Pywikipedia-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikipedia-l
--
Nicolas Dumazet — NicDumZ