On 03/01/2014 10:10 AM, Prateek Saxena wrote:
Hey,
Matt(superm401) merged my patch relating to animation to
mediawiki/core a few days back (yay!! \o/). I asked him if it made
sense to add some basic animations (slideUp, fadeInUp) to core so that
more extensions can make use of it. He said that not too many
extensions are using animation and thus it doesn't make sense to add
more things to core (I agree).
I just suggested it would be better if it were used in either core
(obviously if it's used in core, it has to be in the core mixins file),
or a couple extensions (so not every extension has to be necessarily put
animations in core right away, similar to other CSS).
I agree if there's evidence it would be useful in more than one
extension, it makes sense to think about putting it in core.
The approach proposed (put it in the extensions first, factor out soon
after if a couple share the same animation) seems fine.
A remaining concern is not cluttering unrelated (generated) CSS files
with keyframes, but we're on the same page about that.
Matt Flaschen