On Wed, Mar 5, 2014 at 8:51 AM, Steven Walling <swalling(a)wikimedia.org> wrote: In addition to that... the author is asking if Save page should be mw-ui-constructive (green). That's correct right? mw-ui-primary is actually deprecated in the new version, and save is not a multi-step action so it's not mw-ui-progressive (blue). Jared? -- Steven Walling, Product Manager https://wikimediafoundation.org/ _______________________________________________ Design mailing list Design(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design

I'm not sure about changing the text. That might be too attention-grabbing.

I'm not sure about changing the text. That might be too attention-grabbing.

Pau has a good point if we keep the strings a single word when possible (language) the distraction should be minimized. Especially since we should try to do a quick but subtle fade between the two black text strings shouldn't be that distracting. Sent while mobile On Mar 6, 2014, at 12:50 AM, Pau Giner <pginer(a)wikimedia.org> wrote: I'm not sure about changing the text. That might be too If changing the text makes the action more contextual, it tends to work well. We applied and tested with users similar approaches [1]. some examples are the Draft namespace prototypes (where "publish draft" turns into "save" once there are changes) and the translate extension (where possible outdated translations have "Confirm translation" as the initial action and it turns into "Save" when the user modifies the translation). A possible distraction can be produced if the change in text length has a big impact, but you can play with min-width to compensate that (giving some extra room to the button which is expected to grow). In this case, since we are talking about silent buttons, that is even less of a problem (compared to colourful primary action buttons). [1] Testing sessions for draft namespaces available at https://www.mediawiki.org/wiki/Draft_namespace/Usability_testing/Results On Thu, Mar 6, 2014 at 6:22 AM, Matthew Flaschen <mflaschen(a)wikimedia.org>wrote;wrote: > On 03/05/2014 12:33 PM, Jared Zimmerman wrote: > >> That's partly (but not strongly) why I think both should be quiet >> destructive. But since both would be quiet, either quiet neutral >> (cancel) or quiet destructive (discard) the user won't actually see a >> color change or appearance when they enter text. >> > > I think the idea of starting quiet neutral, and changing to quiet > destructive when they have (unsaved) changes, makes sense. I agree it > shouldn't be too attention-grabbing, since quiet buttons are not visible > until hover/focus. > > I'm not sure about changing the text. That might be too > > > For non-JS I'll say what I always say. We should have a graceful >> controlled degradation for these users. In this can they will see no >> change. eg. the button will always say cancel , and not change based on >> their actions. >> > > Yes, I think this is fine. > > For the core edit page, I filed as https://bugzilla.wikimedia. > org/show_bug.cgi?id=62304 . There is also a Flow one S filed at > https://bugzilla.wikimedia.org/show_bug.cgi?id=62290 > > Matt Flaschen > > > _______________________________________________ > Design mailing list > Design(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/design > -- Pau Giner Interaction Designer Wikimedia Foundation _______________________________________________ Design mailing list Design(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design _______________________________________________ Design mailing list Design(a)lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/design

That's partly (but not strongly) why I think both should be quiet destructive. But since both would be quiet, either quiet neutral (cancel) or quiet destructive (discard) the user won't actually see a color change or appearance when they enter text.

The current proposed change to use mw-ui-button for save/preview/show changes/cancel (on the edit screen) uses mw-ui-destructive (with quiet) for the cancel button. This directly contradicts the style guide, which says, "This should not be used for cancel buttons.". As noted at https://gerrit.wikimedia.org/r/#/c/116725/ , my understanding of destructive is that you are deleting something that was already publicly visible, or at least has an impact beyond your own personal session. The cancel button doesn't seem to fit that. Cancel is a common concept, and semantically clear, so perhaps we should simply add mw-ui-cancel.