Fixes captcha
PS. Are we aware account creation is impossible without JavaScript on
desktop (on mobile it is fine..)..?
On Tue, Jul 29, 2014 at 5:43 PM, Jon Robson <jdlrobson(a)gmail.com> wrote:
Hi Steven
On Tue, Jul 29, 2014 at 1:29 PM, Steven Walling <swalling(a)wikimedia.org> wrote:
Hi all,
In the interest of closer collaboration, Jon and Matt have merged a patch to
upstream new mw-ui-input styles, which I believe originated in Flow. It's at
https://gerrit.wikimedia.org/r/#/c/149173/
I'm glad we merged this sooner rather than later, since it means there are
fewer Flow-specific overrides on top of mediawiki.ui and it forces us to
have a cross-team discussion. However, with the new input styles going out
on desktop search, log in, and create account there are some design issues
we need to resolve.
Yes, I'm sure there will be some teething problems but right now I
think getting our teams using standard UI elements and site
consistency should be the top priority.
This appears to have caused a regression, where the CAPTCHA input field on
create account is not styled correctly. It's now way too small for the
container.
I'm working on a fix as we speak.
We now have multiple indicator styles showing up.
In form fields, the blue
bar on the left appears. On elements like page links and checkboxes, the
softer blue outline appears. This mixed experience is distracting.
Can you give some example pages of this?
The left-aligned blue bar is way too close to the
cursor, and makes it
harder to see where it is. In an RTL language like Hebrew, the blue bar
overlaps entirely with the cursor.
I will let designers comment on that
You can see all of these by checking out the relevant forms on Beta Labs
right now. You can see the previous forms on English Wikipedia, or via the
style guide (which hasn't been updated yet):
Please please please someone find a way to auto-update this. This is
supposed to be a living style guide and that's embarrassing :) Any
takers?
On a side note: whether we decide to stick with the design or not, we
only now need to change it in one place and I think that's awesome.
PS. Please make mediawiki ui checkboxes happen:
https://gerrit.wikimedia.org/r/#/c/149121/ it would be great to have
BetaFeatures, core and other extensions using the same checkbox
element!