On Apr 4, 2014 12:48 PM, "Quim Gil" <qgil(a)wikimedia.org> wrote:
On Friday, April 4, 2014, Brad Jorsch (Anomie) <bjorsch(a)wikimedia.org>
wrote:
> On Thu, Apr 3, 2014 at 7:10 PM, Quim Gil <qgil(a)wikimedia.org
<javascript:;>>
> wrote:
>
> > The queue of open chagesets keeps growing.
>
>
> Does "open" include changesets that were submitted, got feedback, and
then
the submitter
never bothered to follow up?
Yes, shouldn't we?
Open is open. What would be the best practice with these changesets? Just
leave them open like now, abandon them, mark them with some tag...?
Best practise is for author to abandon them if they are not interested any
more. However very few people actually do that. If you want to exclude
them, -1 is a good criteria (-1 patchsets are not waiting on review, so
even if there is still interest, its not in queue).
Some [wip] patches are probably also outliers in the data set and should be
excluded.
If you want to know median time to review, i would suggest only counting
merged patches, since open patches have an unknown time to review (not sure
if this is what you are already doing).
-bawolff