Hi Nick,
Nick Jenkins wrote:
Hi Julien,
The latest version of the sources with all these modifications is available at : http://suggest.speedblue.org/tgz/wikipedia-suggest-0.31.tar.gz
Some search suggestion updates:
- Got rid of the race condition in autocomplete when user types fast (e.g. can type "new" fast without having it lose the
highlighting on " York").
- Removed the first field from the JSON response from TcpQuery (basically client was asking a question, and getting a response from
server that said "the question you asked is this, and the answer is this" - however we only need the answer back, not the question). Also removed a handful of spaces that aren't needed in the JSON data.
- Pressing "Enter" on a response which has no matches will now invoke MediaWiki's "Special:Search" on that query.
- Moved the URL to the wiki to index.php (as "var baseUrl"), which hopefully means that a single WSuggest.js file can be used for
both English and French.
- Added a CHANGELOG file to keep track of what's changed + release dates.
- With the "var autocomplete" + delete key stuff (intKey == 8), I think the intent was to update the suggestion list (but not the
autocomplete) if the user presses the backspace/delete keys. Added a 'showAutocomplete' boolean parameter for this.
- If the user searched for "XYZ Affair", then deleted the "Y" to give "XZ Affair", it would still show "XYZ Affair" as the only
matching result (when really there are no matching results). To prevent this removed the 'cache' boolean var.
Patch against 0.31 is at http://files.nickj.org/MediaWiki/wikipedia-suggest-0.31-diff.txt
Very good job, I will integrate your patch in the 0.4 version that I will release tomorrow. Thank you very much.
Best Regards. Julien