On 5/29/05, Dori <slowpoke(a)gmail.com> wrote:
Not having looked at the patch or the code, I think he
was saying that
a thumb would get generated even if the width of the image is the same
as the would-be thumb.
Yes, that's what I meant. Sorry to be unclear.
I'll list it on Bugzilla tomorrow. The patch is simply:
--- includes/Image.php 28 May 2005 06:57:59 -0000 1.96
+++ includes/Image.php 30 May 2005 02:52:42 -0000
@@ -907,7 +907,7 @@
return null;
}
- if( $width > $this->width && !$this->mustRender() ) {
+ if( $width >= $this->width && !$this->mustRender() ) {
# Don't make an image bigger than the source
return new ThumbnailImage(
$this->getViewURL(), $this->getWidth(), $this->getHeight() );
}
(silly binary attachments!)