Josh Cogliati wrote:
Timwi, Thanks for the version of the patch. I have some questions though. On Thu, Jul 08, 2004 at 12:07:08PM +0100, Timwi wrote:
- Change it to a special page?
No, please not!... I don't like special pages because they make the tabs disappear. :) I'd really rather prefer if Special:Movepage were converted to a simple &action=move thingie.
Tim Starling made the argument that special pages were easier to link to and did not involve adding more UI stuff to Article.php.
I said something else too, but you left IRC a few seconds before I was able to say it.
Would it be quicker to turn this into two query? Where the second query is something like:
$sql = "SELECT COUNT(DISTINCT old_user_text) FROM old WHERE ".$old_clause . " AND old_user_text != " . $cur_author; Then you can always $authors++ since the current author will not appear in the second query. So the second query is becomes more complicated, but the third query is unneeded.
It doesn't matter which way you do it, it's going to be very slow on the live site. Any query which involves loading every row of the old table for a particular article will take at least a couple of minutes to complete for pages with large histories. This query:
SELECT old_user FROM old WHERE old_title ='Main_Page' and old_namespace=0 UNION SELECT cur_user FROM cur WHERE cur_title ='Main_Page' and cur_namespace=0;
...took almost 2 minutes on suda in a relatively quiet part of the day. I wasn't game to try it on the village pump. Before we can include this on the live site, we will need to make it efficient. Have you considered keeping a list of authors in a field in the cur table, and updating it when the article is saved?
-- Tim Starling