<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 03/16/2016 02:33 AM, Rob Lanphier
wrote:<br>
</div>
<blockquote
cite="mid:CAPzpXh40DameEmBYHx3ByVywhos+xWMpCo11bXMjQYbP7J0M2Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Tue, Mar 15, 2016 at 8:03 PM,
Mukunda Modell <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:mmodell@wikimedia.org" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:mmodell@wikimedia.org">mmodell@wikimedia.org</a></a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div class="gmail_extra">
<div class="gmail_quote"><span class="">On Tue,
Mar 15, 2016 at 6:48 PM, Kevin Smith <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:ksmith@wikimedia.org"
target="_blank">ksmith@wikimedia.org</a>></span>
wrote:<br>
</span>
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div class="gmail_extra"><span class="">
<div>I would mention that in some cases,
I would prefer to accept the commit as
is, and then perform minor
refactoring, such as changing a name,
fixing a typo, or rearranging the
code. Not only does that clearly
separate authorship, but it would also
encourage those changes to be reviewed
by someone other than that author. <br>
</div>
</span></div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
<br>
This works when CI jobs aren't red. When CI jobs are red (for
example, jscs / jshint style guide for javascript which would count
as minor tweaking), it might sometimes be faster for the reviewer to
fix them and merge them.<br>
<br>
<blockquote
cite="mid:CAPzpXh40DameEmBYHx3ByVywhos+xWMpCo11bXMjQYbP7J0M2Q@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>
<div>
<div class="gmail_extra">This ^ <br>
<br>
</div>
<div class="gmail_extra">I think this says what I've
been trying to say, only better. </div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>Thank you Kevin and Mukunda. I think I still probably
disagree with you, but I understand what you're trying to
say a lot better now, and I'm now in the "mild
disagreement" category.</div>
<div><br>
</div>
<div>My mild disagreement: I think it's good to have a
system where people collaborate on a patch before it lands
in trunk/mainline. Subbu's case seems reasonable to me. <br>
</div>
</div>
</div>
</div>
</blockquote>
<br>
To be clear, for sure, we can find other ways of collaboration and
other ways of fixing / amending patches.<br>
<br>
But, overall, I haven't understood why the tool has to be so
opinionated about this. It seems more flexibility is better ..
having a flag letting projects turn on/off this feature seems a
better approach rather than dictate workflows for all users /
projects?<br>
<br>
Subbu.<br>
</body>
</html>