[teampractices] Code review social norms

[Alex Monk]

It's interesting, but I'm struggling to figure out how Wikimedia fits in
here. He does quite a bit of talking about 'New hires' etc., and 'I am
concerned about building features that make the "Open Source Contributor /
Intern" case a little better but gut the principles of equality, ownership
and accountability from the "New Hire" case' is somewhat worrying language.

And toxicity...
>Broadly, the Phabricator upstream has mostly moved from "arc patch + amend
locally + arc land" to "almost never accept patches from contributors",
which has worked well for us, but this is obviously an unusual stance for
an open source project to take and presumably toxic conceptually and
actively goal-defeating in the WMF downstream.

He's correct of course about this - this idea would practically be the end
of the Wikimedia technical community as far as I am concerned. It
absolutely should be considered toxic, and is one of the things that keeps
me away from attempting to contribute upstream as much as I might otherwise.

Also, +1 to everything James said.

On 14 March 2016 at 19:15, Greg Grossmeier <greg at wikimedia.org> wrote:

> (CC'ing Matt F who lead the "Make code review not suck" session at
> WikiDev16, not sure if his on the list or not.)
>
> Related to the other code-review for WMF teams discussion I'd like to
> pass along some feedback from Evan Priestley (the Phabricator lead dev)
> on how we currently do code-review in Gerrit. Specifically the issue of
> amending other people's patches.
>
> Backgroun:
> * This started as this task in our Phab:
>   https://phabricator.wikimedia.org/T121751 "Document best practices to
>   amend a change written by another contributor"
> * Lot's of discussion there about what is "right" in the general sense.
> * Mukunda found out a way of making everyone happy (maybe)
> * Mukunda proposed that solution upstream, then Evan P wrote a long
>   opinion piece on code review social contracts and basically concluded
>   that our social contracts are toxic (a theme we keep hearing...)
> ** here: https://secure.phabricator.com/T10584
>
> I won't copy/paste it all as it's long and I don't want to lose
> formatting, but I think it's worth while for those of us on this list to
> read and think about.
>
> Greg
>
> --
> | Greg Grossmeier            GPG: B2FA 27B1 F7EB D327 6B8E |
> | identi.ca: @greg                A18D 1138 8E47 FAC8 1C7D |
>
> _______________________________________________
> teampractices mailing list
> teampractices at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/teampractices
>



-- 
Alex Monk
VisualEditor/Editing team
https://wikimediafoundation.org/wiki/User:Krenair_(WMF)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/teampractices/attachments/20160314/3235ca84/attachment-0001.html>