[QA] Ruby Coding Conventions and RuboCop (was: Rubocop style checker)

Dan Duvall dduvall at wikimedia.org
Thu Nov 20 17:48:44 UTC 2014


On 20 Nov 2014, at 01:48, S Page <spage at wikimedia.org> wrote:
>
> Speaking of overzealous rules, The Flow rubocop job was failing on its
> Gemfile:
>
> *02:53:31* Gemfile:1:1: C: Missing space after #.*02:53:31* #ruby=ruby-2.1.1*02:53:31* ^^^^^^^^^^^^^^^^*02:53:31* Gemfile:2:1: C: Missing space after #.*02:53:31* #ruby-gemset=Flow*02:53:31* ^^^^^^^^^^^^^^^^^
>
> but all our Gemfiles are written this way.
>
> One alternative to this annotation would be to use .ruby-version and
.ruby-gemset files in the project. They former is standard-ish (supported
by Ruby versioning tools other than RVM).[1]

[1] http://rvm.io/workflow/projects#project-file-ruby-version

On Thu, Nov 20, 2014 at 9:15 AM, Krinkle <krinklemail at gmail.com> wrote:

> It seems robocop requires quite verbose configuration making it less
> attractive to maintain in individual repositories. Perhaps we can inherit
> some kind of base config with only minor local changes, or even upstream
> our conventions, like I did for jscs.
>

I like that idea, especially if we can agree on a liberal base
configuration.

-- 
Dan Duvall
Automation Engineer
Wikimedia Foundation <http://wikimediafoundation.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/qa/attachments/20141120/b11d14e8/attachment-0001.html>


More information about the QA mailing list