[QA] [WikimediaMobile] big improvements to the MobileFrontend browser test repo

Joaquin Oltra Hernandez jhernandez at wikimedia.org
Fri Dec 5 09:23:34 UTC 2014

Thanks for all the work Chris.

Not long ago I followed all instructions here
but I can't get all the tests to pass so I'm not sure if there is something
else to configure or enable, so I figured I'd ask before starting to look
into the individual tests.

Here you can see vagrant roles, final output of the tests and env variables

I'm running the tests with phantomjs by default for convenience and speed,
but I've tried Firefox and I've gotten similar results.

Anything I've missed that I should do? I'd really love to get them green to
rely on them more often and avoid regressions.

On Thu, Dec 4, 2014 at 11:43 PM, Chris McMahon <cmcmahon at wikimedia.org>

> Hi mobile folk,
> After 48 patches merged, I have updated all the browser tests in the
> MobileFrontend repo to conform to RSpec3 syntax. Along the way I did a few
> other things:
> * removed every sleep() statement except one necessary to get around a bug
> in Chrome
> * consolidated the lines within each step in each test to be as succinct
> as possible
> * handled and removed a number of FIXME comments
> * removed a significant amount of dead/unused/irrelevant code
> * made the Feature description of each test step consistent with what each
> step actually accomplishes
> * removed all the instances where "Then" steps were re-used as Given or
> When (they are conceptually different)
> On the style front:
> * all the steps are now in alphabetical order according to
> Given/When/Then, and all the GWT specifications in the .feature files
> conform to their corresponding implementations in steps files.
> * in the Features, every Then step contains the word "should", in the
> steps files, every Then step contains an RSpec assertion
> * no Given or When steps contain either the word "should" or an RSpec
> assertion
> This all should make working in the browser test repo significantly easier
> and more straightforward, as well as making far better use of the most
> modern implementation of RSpec.
> For my next trick I am going to make the browser test repo conform as
> closely as possible to rubocop style rules, but the heavy lifting with
> regard to technical debt in the browser test repos is mostly handled.
> Let me know if you have any questions or if you would like a tour...
> -Chris
> _______________________________________________
> Mobile-l mailing list
> Mobile-l at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/mobile-l
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/qa/attachments/20141205/654a9ecd/attachment.html>

More information about the QA mailing list