[QA] QA Code review help needed

Jon Robson jrobson at wikimedia.org
Tue Apr 15 23:56:53 UTC 2014


Thanks a bunch Chris for the help with this today!


On Tue, Apr 15, 2014 at 11:37 AM, Jon Robson <jrobson at wikimedia.org> wrote:
> This is fixed now. The patch was fine just for some reason when Chris
> checked it out it wasn't based properly of the latest version of
> master.
> Help still needed on the other patchsets! I'm being very attentive today! :)
>
>
> On Tue, Apr 15, 2014 at 10:09 AM, Chris McMahon <cmcmahon at wikimedia.org> wrote:
>>
>> Hi Jon,
>>
>> This one https://gerrit.wikimedia.org/r/#/c/125008/ will unblock many of the
>> ones in the queue.  It needs to create a "Selenium no languages test page"
>> in order to pass.
>>
>>
>> On Tue, Apr 15, 2014 at 9:57 AM, Jon Robson <jrobson at wikimedia.org> wrote:
>>>
>>> I'm pretty swamped with patches that are needing review. Any help with
>>> these would be much appreciated.
>>>
>>> ####
>>>
>>> 03: QA 1807: Provide tests for full text search (by Jdlrobson, 6 days old)
>>> [0]
>>> https://gerrit.wikimedia.org/r/124742
>>>
>>> 06: QA: Login before opting into beta (by Jdlrobson, 0 days old) [0]
>>> https://gerrit.wikimedia.org/r/125890
>>>
>>> 07: QA: Remove dependency on "Foo bar" article (by Jdlrobson, 0 days old)
>>> [0]
>>> https://gerrit.wikimedia.org/r/125861
>>>
>>> 08: QA: Remove dependency on diff test page (by Jdlrobson, 0 days old) [0]
>>> https://gerrit.wikimedia.org/r/125860
>>>
>>> 09: QA: Identify the license link better (by Jdlrobson, 0 days old) [0]
>>> https://gerrit.wikimedia.org/r/125863
>>>
>>> 10: QA: Begin removing dependency on Barack Obama article (by
>>> Jdlrobson, 0 days old) [0]
>>> https://gerrit.wikimedia.org/r/125862
>>>
>>> 11: QA: Make the test environment agnostic of existing pages #2 (by
>>> Jdlrobson, 0 days old) [0]
>>> https://gerrit.wikimedia.org/r/125857
>>>
>>> 12: QA: Remove dependency on Duel Masters article (by Jdlrobson, 0 days
>>> old) [0]
>>> https://gerrit.wikimedia.org/r/125859
>>>
>>> 13: Hygiene: Move wgSiteName requirement into other LocalSettings
>>> changes (by Jdlrobson, 0 days old) [0]
>>> https://gerrit.wikimedia.org/r/125858
>>>
>>> _______________________________________________
>>> QA mailing list
>>> QA at lists.wikimedia.org
>>> https://lists.wikimedia.org/mailman/listinfo/qa
>>
>>
>>
>> _______________________________________________
>> QA mailing list
>> QA at lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/qa
>>



More information about the QA mailing list