[Pywikipedia-l] [Pywikipedia-svn] SVN: [8562] trunk/pywikipedia/wikipedia.py

[Dr. Trigon]

And again: Thanks a lot!!!

Greetings

Am 15.09.2010 14:54, schrieb xqt at svn.wikimedia.org:
> Revision: 8562
> Author:   xqt
> Date:     2010-09-15 12:54:46 +0000 (Wed, 15 Sep 2010)
>
> Log Message:
> -----------
> pre"loading" version history, submitted by DrTrigon.
> Fix for old bug: VH was never reloaded if len(VH)<  revCount.
>
> Modified Paths:
> --------------
>      trunk/pywikipedia/wikipedia.py
>
> Modified: trunk/pywikipedia/wikipedia.py
> ===================================================================
> --- trunk/pywikipedia/wikipedia.py	2010-09-15 11:32:15 UTC (rev 8561)
> +++ trunk/pywikipedia/wikipedia.py	2010-09-15 12:54:46 UTC (rev 8562)
> @@ -2559,8 +2559,11 @@
>                   dataQuery = self._versionhistoryearliest
>               else:
>                   thisHistoryDone = True
> -        elif not hasattr(self, '_versionhistory') or forceReload:
> +        elif not hasattr(self, '_versionhistory') or forceReload or \
> +             len(self._versionhistory)<  revCount:
>               self._versionhistory = []
> +        # ?? does not load if len(self._versionhistory)>  revCount
> +        # shouldn't it
>           elif getAll and len(self._versionhistory) == revCount:
>               # Cause a reload, or at least make the loop run
>               thisHistoryDone = False
> @@ -3907,7 +3910,7 @@
>           successful = False
>           for page2 in self.pages:
>               if page2.sectionFreeTitle() == page.sectionFreeTitle():
> -                if not (hasattr(page2,'_contents') or hasattr(page2,'_getexception')) or self.force:
> +                if not (hasattr(page2,'_contents') or hasattr(page2, '_getexception')) or self.force:
>                       page2.editRestriction = entry.editRestriction
>                       page2.moveRestriction = entry.moveRestriction
>                       if editRestriction == 'autoconfirmed':
> @@ -3917,6 +3920,7 @@
>                       page2._ipedit = ipedit
>                       page2._revisionId = revisionId
>                       page2._editTime = timestamp
> +                    page2._versionhistory = [(revisionId, str(Timestamp.fromtimestampformat(timestamp)), username, entry.comment)]
>                       section = page2.section()
>                       # Store the content
>                       page2._contents = text
>
>
>
> _______________________________________________
> Pywikipedia-svn mailing list
> Pywikipedia-svn at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/pywikipedia-svn