[Pywikipedia-l] [ pywikipediabot-Bugs-2082329 ] movepages.py with -del does not delete talk page redirect

[SourceForge.net]

Bugs item #2082329, was opened at 2008-08-29 14:11
Message generated for change (Comment added) made by yannforget
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2082329&group_id=93107

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Uberfuzzy (uberfuzzy)
Assigned to: Nobody/Anonymous (nobody)
Summary: movepages.py with -del does not delete talk page redirect

Initial Comment:
Pywikipedia [http] trunk/pywikipedia (r5858, Aug 28 2008, 11:35:51)
Python 2.5.1 (r251:54863, Apr 18 2007, 08:51:08) [MSC v.1310 32 bit (Intel)]


when using the movepages.py script with the -del option to delete the leftover redirect, only the redirect for the page is deleted, but not the talk page redirect.

----------------------------------------------------------------------

Comment By: Yann Forget (yannforget)
Date: 2008-11-25 16:07

Message:
Thanks to Andre Engels who helped for this, please add to movepages.py:

86c86
<     def __init__(self, generator, addprefix, delete, always,
skipredirects, summary, leaveRedirect):
---
>     def __init__(self, generator, addprefix, delete, always,
skipredirects, summary):
93d92
<       self.leaveRedirect = leaveRedirect
101c100
<             if page.move(newPageTitle, msg, throttle=True,
leaveRedirect=self.leaveRedirect) and self.delete:
---
>             if page.move(newPageTitle, msg, throttle=True) and
self.delete:
223d221
<     leaveRedirect = True
249,250d246
<       elif arg == '-noredirect':
<             leaveRedirect = False
284c280
<         bot = MovePagesBot(None, prefix, delete, always, skipredirects,
summary, leaveRedirect)
---
>         bot = MovePagesBot(None, prefix, delete, always, skipredirects,
summary)
288c284
<         bot = MovePagesBot(preloadingGen, prefix, delete, always,
skipredirects, summary, leaveRedirect)
---
>         bot = MovePagesBot(preloadingGen, prefix, delete, always,
skipredirects, summary)


----------------------------------------------------------------------

Comment By: Yann Forget (yannforget)
Date: 2008-11-25 13:40

Message:
https://sourceforge.net/tracker/index.php?func=detail&aid=2255146&group_id=93107&atid=603141


----------------------------------------------------------------------

Comment By: Multichill (multichill)
Date: 2008-11-13 13:06

Message:
Mediawiki now supports moving pages without leaving redirects for bots.
Maybe the -del option should just move the page with this option enabled,
save you the deleting of a useless page.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=603138&aid=2082329&group_id=93107