[Pywikipedia-l] SVN: [5320] trunk/pywikipedia/welcome.py

[nicdumz at svn.wikimedia.org]

Revision: 5320
Author:   nicdumz
Date:     2008-05-07 13:37:59 +0000 (Wed, 07 May 2008)

Log Message:
-----------
* Special:Log has changed. -offset:# is not available anymore, only -offset:TIMESTAMP is (bug #1959384)
* Using Site method to get Special:Log instead of hardcoded value

Modified Paths:
--------------
    trunk/pywikipedia/welcome.py

Modified: trunk/pywikipedia/welcome.py
===================================================================
--- trunk/pywikipedia/welcome.py	2008-05-07 10:09:52 UTC (rev 5319)
+++ trunk/pywikipedia/welcome.py	2008-05-07 13:37:59 UTC (rev 5320)
@@ -59,8 +59,11 @@
     -limit[:#]     Use this parameter to define how may users should be
                    checked (default:50)
 
-    -offset[:#]    Skip the latest # new users to give interactive users
-                   a chance to welcome the new user (default: 0)
+    -offset[:TIME] Skip the latest new users (those newer than TIME) 
+                   to give interactive users a chance to welcome the 
+                   new users (default: now)
+                   Timezone is the server timezone, GMT for Wikimedia
+                   TIME format : yyyymmddhhmmss
 
     -numberlog[:#] The number of users to welcome before refreshing the
                    welcome log (default: 4)
@@ -565,9 +568,12 @@
                 time_variable = int(arg[6:])
         elif arg.startswith('-offset'):
             if len(arg) == 7:
-                offset_variable = int(wikipedia.input(u'Which offset for new users would you like to use?'))
+                offset_variable = int(wikipedia.input(u'Which time offset for new users would you like to use?'))
             else:
                 offset_variable = int(arg[8:])
+            if len(str(offset_variable)) != 14:
+                # upon request, we might want to check for software version here
+                raise ValueError("Mediawiki has changed, -offset:# is not supported anymore, but -offset:TIMESTAMP is, assuming TIMESTAMP is yyyymmddhhmmss. Please read this script source header for documentation.")
         elif arg.startswith('-file:'):
             random = True
             fileOption = True
@@ -748,11 +754,11 @@
         say_hi = ("S", "s", "Saluto", "saluto", "Welcome", "welcome", 'w', 'W', 'say hi',
                 'Say hi', 'Hi', 'hi', 'h', 'hello', 'Hello')
 
-        # The URL for new users is the same in every project. It should not be changed.
-        if offset_variable == 0:
-            URL = "/w/index.php?title=Special:Log&type=newusers&limit=%d" % limit
-        else:
-            URL = "/w/index.php?title=Special:Log&type=newusers&limit=%d&offset=%d" % (limit, offset_variable)
+        # think about non-wikimedia wikis. Use Site functions.
+        URL = wsite.log_address(limit, 'newusers') 
+        if offset_variable != 0:
+            URL += "&offset=%d" % offset_variable
+        print URL
         log = wsite.getUrl(URL)
         wikipedia.output(u'Loading latest %s new users from %s...\n' % (limit, wsite.hostname()))
         # Determine which signature to use