[MediaWiki-l] Missing tests/ directory in 1.23.1-5

Daniel Renfro drenfro at vistaprint.com
Thu Oct 23 17:50:31 UTC 2014


I think not including the tests/ directory is wrong. Not only is the release incomplete, it is inconsistent -- there is code that breaks when run (references to files that do not exist.) In my opinion, a robust open source software package such as MediaWiki should be proud to ship its unit-tests. The 4MB of tests don't significantly contribute to the size of the release (some 80MB+.)

Now, to reconstruct the tests, not only do I have to go dig up the release branch, but REL1_23 doesn't contain the standard extensions (or their tests.) Now I have manually hunt down each extension and copy, find the appropriate branch, and copy it's tests/ directory over. All just to run the normal test-suite.  

--Daniel


-----Original Message-----
From: mediawiki-l-bounces at lists.wikimedia.org [mailto:mediawiki-l-bounces at lists.wikimedia.org] On Behalf Of Gordon Joly
Sent: Thursday, October 23, 2014 7:32 AM
To: mediawiki-l at lists.wikimedia.org
Subject: Re: [MediaWiki-l] Missing tests/ directory in 1.23.1-5


This needs to cross referenced to recent patches, perhaps?

In particular patches to create 1.23.2 and 1.23.3?

mediawiki-1.23.2/tests/phpunit/includes/GlobalFunctions/wfShellExecTest.php

mediawiki-1.23.3/tests/phpunit/includes/GlobalFunctions/wfShellExecTest.php

Gordo


*******************************
x1:~/src# grep -i tests  *patch
mediawiki-1.23.3.patch:diff -Nruw -x messages -x '*.png' -x '*.jpg' -x '*.xcf' -x '*.gif' -x '*.svg' -x '*.tiff' -x '*.zip' -x '*.xmp' -x '.git*'
mediawiki-1.23.2/tests/phpunit/includes/GlobalFunctions/wfShellExecTest.php
mediawiki-1.23.3/tests/phpunit/includes/GlobalFunctions/wfShellExecTest.php
mediawiki-1.23.3.patch:---
mediawiki-1.23.2/tests/phpunit/includes/GlobalFunctions/wfShellExecTest.php
1970-01-01 00:00:00.000000000 +0000
mediawiki-1.23.3.patch:+++
mediawiki-1.23.3/tests/phpunit/includes/GlobalFunctions/wfShellExecTest.php
2014-08-27 21:44:53.242493016 +0000
mediawiki-1.23.4.patch:+  checks for attributes that contain css; add unit tests for html5sec and mediawiki-1.23.4.patch:diff -Nruw -x messages -x '*.png' -x '*.jpg' -x '*.xcf' -x '*.gif' -x '*.svg' -x '*.tiff' -x '*.zip' -x '*.xmp' -x '.git*'
mediawiki-1.23.3/tests/phpunit/includes/upload/UploadBaseTest.php
mediawiki-1.23.4/tests/phpunit/includes/upload/UploadBaseTest.php
mediawiki-1.23.4.patch:---
mediawiki-1.23.3/tests/phpunit/includes/upload/UploadBaseTest.php
2014-09-24 19:58:10.961599096 +0000
mediawiki-1.23.4.patch:+++
mediawiki-1.23.4/tests/phpunit/includes/upload/UploadBaseTest.php
2014-09-24 19:55:15.538575503 +0000
x1:~/src#


On 22/10/14 21:54, Antoine Musso wrote:
> Le 22/10/2014 20:06, Daniel Renfro a écrit :
>> While looking into upgrading my 1.22.5 installation to 1.23.5, I noticed that the tests/ directory was missing. Looking in git it is there for the REL1_23, but seems to have vanished in the tarballs for releases?
>>
>> Am I missing something? or are these releases incomplete?
>>
>> Sincerely confused,
>> -Daniel   (Us+er:AlephNull)
> 
> Hello Daniel,
> 
> Indeed the release script used to build the tarball learned to ignore 
> some files with https://gerrit.wikimedia.org/r/#/c/123220/
> 
> 
> Here is the ignore list:
> 
> tar:
>   ignore:
>     - "*~"
>     - ".js*"
>     - ".git*"
>     - testsuite
>     - tests
>     - "*.xcf"
>     - "#*#"
>     - ".#*"
>     - .travis.yml
> 
> 
> It is in:
>    mediawiki/tools/release.git
>    make-release/make-release.yaml
> 
> 
> I guess because the tests takes a good chunk of space and people 
> interesting in running them most probably use a Wiki from the release 
> branches.
> 
> 


_______________________________________________
MediaWiki-l mailing list
To unsubscribe, go to:
https://lists.wikimedia.org/mailman/listinfo/mediawiki-l


More information about the MediaWiki-l mailing list