[Mediawiki-l] [MediaWiki-CVS] SVN: [19703] trunk/phase3/maintenance

[Greg Sabino Mullane]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160


> Log Message:
> -----------
> * Schema changes - add id fields to page_restrictions and
> logging tables for future functionality (log entry deletion,
> rewrite of Special:Protectedpages)
...
> +-- This might be useful for single-log-entry deletion, et cetera.

Why not add the new fields at the time when the functionality
is added? I see little point in adding more fields to the schema
if there is only a possible future use, which may very well
necessitate changing the schema again.

+-- Add a sort-key to page_restrictions table.
> +-- First immediate use of this is as a sort-key for coming modifications
> +-- of Special:Protectedpages.
> ...
> +  -- Field for an ID for this restrictions row (sort-key for Special:ProtectedPages)
> +  pr_id int unsigned not null auto_increment,
> +  UNIQUE KEY  pr_id (pr_id),

The page_restrictions table already has a primary key, so what exactly would
this new column add?

- --
Greg Sabino Mullane greg at turnstep.com
PGP Key: 0x14964AC8 200702021331
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFFw4OxvJuQZxSWSsgRAxp6AJ9qM0rMc9+p7hmmCnI0Lo+aI4Wu8QCg76QI
sacUQndBsT9lqDOwUEaAG6M=
=4cW+
-----END PGP SIGNATURE-----