<div dir="ltr"><div class="gmail_default" style="font-family:tahoma,sans-serif">I have more concerns about Phabricator and I am going to follow Ladgroup's suit and express them here, but feel free to redirect me:<br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">1) With recent changes, Phabricator now uses Diffusion over Gerrit. Even though Diffusion is presumably just "mirroring" Gerrit for most projects, still when you go to a project's page the cloning URI you get is a Diffusion URI. If I clone using that and submit a patch, it won't go to Gerrit. That means the patch won't be reviewed. This is bad practice.<br><br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">2) When I go to a project's page (e.g. <a href="https://phabricator.wikimedia.org/project/view/203/">https://phabricator.wikimedia.org/project/view/203/</a> ), it does not provide a link to its Diffusion page (e.g. <a href="https://phabricator.wikimedia.org/diffusion/ECHU/">https://phabricator.wikimedia.org/diffusion/ECHU/</a> ). Finding a project's source needs several clicks. (Is it the same complaint Ladsgroup made?)<br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">3) The SSH clone URI always starts with vcs@git-ssh ...; unless I totally don't get how it work with Diffusion, I expect the git SSH URIs to start with one's username (in my case huji@git-ssh ..., just like the case with Gerrit where we use something like <span class=""><em>ssh</em>://<USERNAME>@<a href="http://gerrit.wikimedia.org:29418/">gerrit.wikimedia.org:29418/</a><em>mediawiki</em></span>/ ). I would expect that when I am logged in to Phabricator, it also shows me a clone URI that already contains my username.<br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Overall, I like Phabricator over Gerrit (it is unified, has better UI, etc.) but I am at a point (again!) where I feel like the core developers who do this for a living are changing things around without paying attention to usability and documentation to the point that occasional developers like me could also quickly contribute.<br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif"></venting off><br><br></div><div class="gmail_default" style="font-family:tahoma,sans-serif">Huji<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 27, 2016 at 9:00 PM, Bryan Davis <span dir="ltr"><<a href="mailto:bd808@wikimedia.org" target="_blank">bd808@wikimedia.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sat, Aug 27, 2016 at 4:40 PM, Bryan Davis <<a href="mailto:bd808@wikimedia.org">bd808@wikimedia.org</a>> wrote:<br>
> On Sat, Aug 27, 2016 at 1:50 PM, Magnus Manske<br>
> <<a href="mailto:magnusmanske@googlemail.com">magnusmanske@googlemail.com</a>> wrote:<br>
</span><span class="">>> Should existing, third-party repos be tracked in toolsadmin and/or Phabricator/Differential?<br>
><br>
> I have (undocumented) plans to add support for editing and publishing<br>
> toolinfo.json compatible descriptions for each tool. When this is<br>
> implemented it will support connecting 3rd party hosting to each tool.<br>
><br>
> Right now it is possible to create a Diffusion repo through the admin<br>
> console and then manually set it up as a mirror of an existing GitHub<br>
> repo through the management interface in Phabricator. Kunal managed to<br>
> do this with one of his tools [R1947]. Currently the configuration of<br>
> Phabricator itself only allows connecting to GitHub, but we have one<br>
> bug open to allow another external host. I expect as we talk through<br>
> the reasonable solutions of that issue that we will either open up to<br>
> a slightly larger fixed whitelist and come up with a procedure for<br>
> adding more, or determine that automatic external mirroring is<br>
> undesirable. If the answer ends up being that Wikimedia can't allow<br>
> their main Phabricator to connect to arbitrary 3rd party hosts to<br>
> mirror into Diffusion, I think someone can whip up a tool that can<br>
> poll, fetch and push to manage mirrors for interested tools in a<br>
> weekend. :)<br>
<br>
</span>Related to this, if anyone has a Tool with an existing repository that<br>
is hosted in Diffusion (either directly or mirrored from Gerrit), feel<br>
free to open a ticket in the #Striker project asking to have it<br>
connected with your tool. I can manually alter the permissions on the<br>
Phabricator side to match what the admin console would do for a new<br>
repo and register it with the application's tracking database. I<br>
thought about making some UI for this in the app itself, but decided<br>
that the number of affected users was small enough that I could just<br>
handle it directly instead of introducing clutter.<br>
<br>
h/t to Luke081515 for bringing this topic up on irc to prompt this addendum<br>
<div class="HOEnZb"><div class="h5"><br>
Bryan<br>
--<br>
Bryan Davis Wikimedia Foundation <<a href="mailto:bd808@wikimedia.org">bd808@wikimedia.org</a>><br>
[[m:User:BDavis_(WMF)]] Sr Software Engineer Boise, ID USA<br>
irc: bd808 v:<a href="tel:415.839.6885%20x6855" value="+14158396885">415.839.6885 x6855</a><br>
<br>
______________________________<wbr>_________________<br>
Labs-l mailing list<br>
<a href="mailto:Labs-l@lists.wikimedia.org">Labs-l@lists.wikimedia.org</a><br>
<a href="https://lists.wikimedia.org/mailman/listinfo/labs-l" rel="noreferrer" target="_blank">https://lists.wikimedia.org/<wbr>mailman/listinfo/labs-l</a><br>
</div></div></blockquote></div><br></div>