[HipHop] Setting up

[Aaron Schulz]

Hi,
Good work tracking that down. I've posted
https://gerrit.wikimedia.org/r/#/c/63824/ .


On Tue, May 14, 2013 at 8:01 PM, Paul Tarjan <pt at fb.com> wrote:

> Hey wikimedia.
>
> First of all, thanks for making the mailing list :) Did you get hhvm
> running in the labs environment yet?
>
> I tracked down the segfault I alluded to in the meeting. If you want to be
> unblocked before I ship the patch, you can turn this code:
>
>   $link = DatabaseBase::factory( $type )->getSoftwareLink();
>
> into
>
>   $obj = DatabaseBase::factory( $type );
>   $link = $obj->getSoftwareLink();
>
>
> and you shouldn't segfault.
>
> The details if you are interested. getSoftwareLink() is a static method,
> but it is being called on an instance. This works in PHP but we first
> decref the object before calling the method. This object has a desctructor
> which gets called when the refcount goes to 0. In this case, the
> destructor is called right in the middle of setting the stack up for
> getSoftwareLink() and clobbers it. Eventually we segfault with a corrupted
> stack.
>
> I also cleaned up our github issues, so feel free to submit any if you hit
> issues.
>
> Thanks
> Paul
>
>
> _______________________________________________
> HipHop mailing list
> HipHop at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/hiphop
>



-- 
-Aaron S
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.wikimedia.org/pipermail/hiphop/attachments/20130514/eb4c56e3/attachment.html>