<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hello,</p>
<p>Oh, I did not know you used Phabricator. Ok so I will update the
task with my observations about the change.</p>
<p>Best regards,</p>
<p>Diego Abelenda<br>
</p>
<br>
<div class="moz-cite-prefix">On 04/13/2018 04:49 PM, Luca Toscano
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAK1FddsA6hZKsrz75u+5+u83HpHfZG-H-7QpBgNO-6Pe4E8h4A@mail.gmail.com">
<div dir="ltr">Hi Diego,<br>
<div class="gmail_extra"><br>
<div class="gmail_quote">2018-04-13 16:23 GMT+02:00 Diego
Abelenda <span dir="ltr"><<a
href="mailto:diego.abelenda@camptocamp.com"
target="_blank" moz-do-not-send="true">diego.abelenda@camptocamp.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
I am sorry if this is not the correct mailing list to
discuss this.<br>
<br>
<br>
At Camptocamp we are using varnishkafka, and we are
looking to upgrade<br>
to varnish 5.2, however since Varnish broke the VSM API we
will need to<br>
change varnishkafka too.<br>
<br>
Since they decided to make VUT API public, I was thinking
of switching<br>
varnishkafka to it. Hopefully this API will be more stable
than VSM API.<br>
<br>
This would basically transform the whole while block into
a single call<br>
to VUT_Main() with a slightly modified dispatch function
and some call<br>
to VUT_Init/VUT_Setup correct params<br>
(<a
href="https://github.com/wikimedia/varnishkafka/blob/master/varnishkafka.c#L2150-L2195"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://github.com/wikimedia/<wbr>varnishkafka/blob/master/<wbr>varnishkafka.c#L2150-L2195</a>).<br>
<br>
The only blocking point I can see, is the call to
rd_kafka_poll which<br>
will need to be made somehow outside of the "main" thread
since VUT_Main<br>
is a main loop (a periodic call via timer/thread with a
while and<br>
blocking call?).<br>
<br>
I have only analyzed the possibility but not started
coding. I prefer to<br>
have some input first, what do you think of this proposal?<br>
<br>
</blockquote>
<div><br>
</div>
<div>Thanks a lot for reaching out, I opened a while ago a
similar task (<a
href="https://phabricator.wikimedia.org/T177647"
moz-do-not-send="true">https://phabricator.wikimedia.org/T177647</a>)
and the idea was exactly what you proposed, namely
switching to VUT and make the necessary changes for with
Varnish 5.2. We still don't have a clear timeline if/when
we'll migrate to Varnish 5.2 as far as I know, so the work
got a bit de-prioritized, but we can definitely have a
chat on IRC or in the Phabricator task about next steps
and ideas if you wish.</div>
<div><br>
</div>
<div>Luca </div>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>