Hi
I maintain the server running the wiki at https://wiki.transitionnetwork.org/ and 3 month ago it was upgraded to MediaWiki 1.22.x and the VisualEditor was installed from source and that was quite straight forward, details here:
- https://trac.transitionnetwork.org/trac/ticket/706
Yesterday I upgraded to MediaWiki 1.23.0 and switched to using the Debian repo for parsoid as per:
- https://www.mediawiki.org/wiki/Parsoid/Setup#Ubuntu_.2F_Debian
And since then I have been unable to get the VisualEditor working, when you click on 'Edit' nothing happens, looking at the HTTP requests there is a GET to load.php and a 304 in response but nothing actually happens in the web browser, I have tried with Firefox 30 and the Debian Wheezy Chromium.
There is nothing of note in the webserver logs or the parsoid.log.
It appears to be working correctly on the command line:
curl http://localhost:8142/localhost/Sandbox -d wt="Hello ''world''" -d body=1 <body data-parsoid='{"dsr":[0,15,0,0]}'><p data-parsoid='{"dsr":[0,15,0,0]}'>Hello <i data-parsoid='{"dsr":[6,15,2,2]}'>world</i></p></body>
I'm not sure what to try next.
More details including the Nginx config can be found on the comments I have posted to this ticket:
- https://trac.transitionnetwork.org/trac/ticket/736
Any pointers would be greatly appreciated, I fear I have made a simple mistake somewhere...
All the best
Chris
On 06/17/2014 07:40 AM, Chris Croome wrote:
Hi
I maintain the server running the wiki at https://wiki.transitionnetwork.org/
Yay transition network! :-)
and 3 month ago it was upgraded to MediaWiki 1.22.x and the VisualEditor was installed from source and that was quite straight forward, details here:
Yesterday I upgraded to MediaWiki 1.23.0 and switched to using the Debian repo for parsoid as per:
And since then I have been unable to get the VisualEditor working, when you click on 'Edit' nothing happens, looking at the HTTP requests there is a GET to load.php and a 304 in response but nothing actually happens in the web browser, I have tried with Firefox 30 and the Debian Wheezy Chromium.
Did you upgrade the visual editor as well?
If you did, then the version of VE that works with MW 1.23.0 requires you to install the Parsoid extension as well. See https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&oldid... This is to load some css and styling resources that VE needs.
These styles have since been moved to core (https://gerrit.wikimedia.org/r/#/c/130770/) and the parsoid extension is no longer necessary, but the styles are not available in MW 1.23.0.
The other thought I had (since I made this mistake recently and was baffled for a while) was if you installed VE from git, then make sure that after pulling the latest version of VE, you also install VE submodules via git submodule update --init.
Subbu.
On 06/17/2014 07:39 AM, Subramanya Sastry wrote:
Yesterday I upgraded to MediaWiki 1.23.0 and switched to using the Debian repo for parsoid as per:
And since then I have been unable to get the VisualEditor working, when you click on 'Edit' nothing happens, looking at the HTTP requests there is a GET to load.php and a 304 in response but nothing actually happens in the web browser, I have tried with Firefox 30 and the Debian Wheezy Chromium.
Did you adjust the port in the VE config? The Debian package already uses our new default port 8142, as documented in https://www.mediawiki.org/wiki/Parsoid/Setup#Ubuntu_.2F_Debian.
Did you upgrade the visual editor as well?
If you did, then the version of VE that works with MW 1.23.0 requires you to install the Parsoid extension as well.
Note that this was only the case for a short time (~3 weeks IIRC), and I'm not sure that it even made it into any release. Current VE *does not* require the Parsoid extension, as the styles were moved in to core as Subbu noted.
Gabriel
On 17 June 2014 09:49, Gabriel Wicke gwicke@wikimedia.org wrote:
On 06/17/2014 07:39 AM, Subramanya Sastry wrote:
Did you upgrade the visual editor as well?
If you did, then the version of VE that works with MW 1.23.0 requires
you to
install the Parsoid extension as well.
Note that this was only the case for a short time (~3 weeks IIRC), and I'm not sure that it even made it into any release. Current VE *does not* require the Parsoid extension, as the styles were moved in to core as Subbu noted.
However, this requires running an alpha of MediaWiki 1.24, which many sysadmins would rather avoid.
J.
Hi
On Tue 17-Jun-2014 at 10:30:40AM -0700, James Forrester wrote:
On 17 June 2014 09:49, Gabriel Wicke gwicke@wikimedia.org wrote:
Current VE *does not* require the Parsoid extension, as the styles were moved in to core as Subbu noted.
However, this requires running an alpha of MediaWiki 1.24, which many sysadmins would rather avoid.
Indeed, I was hoping that using the 1.23.x (LTS) version would save having to do a major upgrade for a while.
Does anyone have any suggestions regarding what I can do to debug the problem?
All the best
Chris
Hi
On Tue 17-Jun-2014 at 09:49:34AM -0700, Gabriel Wicke wrote:
Did you adjust the port in the VE config? The Debian package already uses our new default port 8142, as documented in https://www.mediawiki.org/wiki/Parsoid/Setup#Ubuntu_.2F_Debian.
Yes, LocalSettings.php has:
$wgVisualEditorParsoidURL = 'http://localhost:8142';
If you did, then the version of VE that works with MW 1.23.0 requires you to install the Parsoid extension as well.
Note that this was only the case for a short time (~3 weeks IIRC), and I'm not sure that it even made it into any release. Current VE *does not* require the Parsoid extension, as the styles were moved in to core as Subbu noted.
Thanks, I have removed it, but I still have no result from clicking 'Edit'.
All the best
Chris
Hi
On Tue 17-Jun-2014 at 09:39:12AM -0500, Subramanya Sastry wrote:
Yay transition network! :-)
:-)
Did you upgrade the visual editor as well?
Yes.
If you did, then the version of VE that works with MW 1.23.0 requires you to install the Parsoid extension as well.
See https://www.mediawiki.org/w/index.php?title=Extension:VisualEditor&oldid... This is to load some css and styling resources that VE needs.
I have tried that but it's not made any difference, notes here:
https://trac.transitionnetwork.org/trac/ticket/736#comment:10
The other thought I had (since I made this mistake recently and was baffled for a while) was if you installed VE from git, then make sure that after pulling the latest version of VE, you also install VE submodules via git submodule update --init.
VisualEditor was downloaded like this:
wget https://codeload.github.com/wikimedia/mediawiki-extensions-VisualEditor/lega... -O VisualEditor.tgz
All the best
Chris
On 18 June 2014 03:21, Chris Croome chris@webarchitects.co.uk wrote:
The other thought I had (since I made this mistake recently and was baffled for a while) was if you installed VE from git, then make sure that after pulling the latest version of VE, you also install VE submodules via git submodule update --init.
VisualEditor was downloaded like this:
wget https://codeload.github.com/wikimedia/mediawiki-extensions-VisualEditor/lega... -O VisualEditor.tgz
… and that's the problem. :-(
The VisualEditor MediaWiki extension has a git submodule for VisualEditor itself (which is a standalone HTML editor without the MediaWiki-specific specialisations).
Unfortunately, Special:ExtensionDistributor blindly gives you a tarball of the extension git repo, which though fine for most extensions is very much not for VisualEditor, which without the submodule is completely and utterly broken. The answer is to not use ExtensionDistributor for VisualEditor (I've asked on the talk page https://www.mediawiki.org/wiki/Extension_talk:ExtensionDistributor#Doesn.27t_do_submodules if it's possible to disable it somehow until this bug is fixed); in the mean time we've slung a full archive of it on releases.wikimedia.org https://releases.wikimedia.org/VisualEditor/VisualEditor-MediaWiki-REL1_23.tar.bz2 (sha1: 7cd90271f91b8ded9d6aae3f9166a11d3c7d0ee9 ) and I'll put a note on the extension's page that will hopefully help .
I'll write a bit of code that visibly errors in the case that the submodule is empty, but that doesn't help people following the very visible (and for this situation wrong) standard instructions on how to install avoiding git. :-(
Incidentally, we just bumped VisualEditor's REL1_23 branch http://git.wikimedia.org/log/mediawiki%2Fextensions%2FVisualEditor.git/refs%2Fheads%2FREL1_23 from a slightly archaïc version to the last possible one before the switch from depending on the Parsoid PHP extension (as well as its node service) to the same content in MediaWiki 1.24. This may fix some wider issues, but won't help with that.
J.
Hi
On Wed 18-Jun-2014 at 07:07:44PM -0700, James Forrester wrote:
On 18 June 2014 03:21, Chris Croome chris@webarchitects.co.uk wrote:
VisualEditor was downloaded like this:
wget https://codeload.github.com/wikimedia/mediawiki-extensions-VisualEditor/lega... -O VisualEditor.tgz
and that's the problem. :-(
However it doesn't appear to be the only problem -- I have installed this version:
https://releases.wikimedia.org/VisualEditor/VisualEditor-MediaWiki-REL1_23.tar.bz2 (sha1: 7cd90271f91b8ded9d6aae3f9166a11d3c7d0ee9)
And I still get the same symptoms, when I click the 'Edit' link nothing happens, and by nothing I mean there isn't a single HTTP request sent as a result.
I also tried reinstalling the Parsoid extension as Subramanya suggested:
- http://lists.wikimedia.org/pipermail/wikitext-l/2014-June/000883.html
But that doesn't appear to have made a difference.
Any further suggestions?
All the best
Chris
On 06/19/2014 01:33 AM, Chris Croome wrote:
However it doesn't appear to be the only problem -- I have installed this version:
https://releases.wikimedia.org/VisualEditor/VisualEditor-MediaWiki-REL1_23.tar.bz2 (sha1: 7cd90271f91b8ded9d6aae3f9166a11d3c7d0ee9)
And I still get the same symptoms, when I click the 'Edit' link nothing happens, and by nothing I mean there isn't a single HTTP request sent as a result.
Are there any errors in the JavaScript console?
I also tried reinstalling the Parsoid extension as Subramanya suggested:
The Parsoid extension was used to register a CSS resource, which was then requested on VE page load (this resource is now in core). Not sure what an error looks like when there are issues in that area. It could be just missing CSS styling for some Parsoid-specific bits.
Gabriel
Hi
On Thu 19-Jun-2014 at 08:52:34AM -0700, Gabriel Wicke wrote:
Are there any errors in the JavaScript console?
Yes, this is what I got when visiting https://wiki.transitionnetwork.org/Sandbox and clicking 'Edit':
Use of getUserData() or setUserData() is deprecated. Use WeakMap or element.dataset instead. requestNotifier.js:52 Use of getAttributeNode() is deprecated. Use getAttribute() instead. load.php:34 Use of attributes' specified attribute is deprecated. It always returns true. load.php:34 Use of getPreventDefault() is deprecated. Use defaultPrevented instead. load.php:48 "Exception thrown by ext.visualEditor.core" load.php:145 "Error: constructor must be a function, cannot be a undefined" Error: constructor must be a function, cannot be a undefined Stack trace: oo.Factory.prototype.register@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... @https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... runScript@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... execute/</checkCssHandles@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... execute/</cssHandle/<@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... jQuery.Callbacks/fire@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... jQuery.Callbacks/self.fireWith@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... jQuery.Callbacks/self.fire@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... addEmbeddedCSS@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... addEmbeddedCSS/<@https://wiki.transitionnetwork.org/load.php?debug=false&lang=en&modu... load.php:145
All the best
Chris
On 23 June 2014 02:47, Chris Croome chris@webarchitects.co.uk wrote:
Hi
On Thu 19-Jun-2014 at 08:52:34AM -0700, Gabriel Wicke wrote:
Are there any errors in the JavaScript console?
Yes, this is what I got when visiting https://wiki.transitionnetwork.org/Sandbox and clicking 'Edit':
Use of getUserData() or setUserData() is deprecated. Use WeakMap or element.dataset instead. requestNotifier.js:52 Use of getAttributeNode() is deprecated. Use getAttribute() instead. load.php:34 Use of attributes' specified attribute is deprecated. It always returns true. load.php:34 Use of getPreventDefault() is deprecated. Use defaultPrevented instead. load.php:48 "Exception thrown by ext.visualEditor.core" load.php:145 "Error: constructor must be a function, cannot be a undefined" Error: constructor must be a function, cannot be a undefined
Ah. Well, that means that there's a breaking change to one of the libraries that VisualEditor requires which made it in to VE REL1_23 but not MW REL1_23. I'll try to find the right version and propose a backport for MW 1.23.1.
Sorry about this. :-(
Yours,
On 24 June 2014 10:58, James Forrester jforrester@wikimedia.org wrote:
On 23 June 2014 02:47, Chris Croome chris@webarchitects.co.uk wrote:
Hi
On Thu 19-Jun-2014 at 08:52:34AM -0700, Gabriel Wicke wrote:
Are there any errors in the JavaScript console?
Yes, this is what I got when visiting https://wiki.transitionnetwork.org/Sandbox and clicking 'Edit':
Use of getUserData() or setUserData() is deprecated. Use WeakMap or element.dataset instead. requestNotifier.js:52 Use of getAttributeNode() is deprecated. Use getAttribute() instead. load.php:34 Use of attributes' specified attribute is deprecated. It always returns true. load.php:34 Use of getPreventDefault() is deprecated. Use defaultPrevented instead. load.php:48 "Exception thrown by ext.visualEditor.core" load.php:145 "Error: constructor must be a function, cannot be a undefined" Error: constructor must be a function, cannot be a undefined
Ah. Well, that means that there's a breaking change to one of the libraries that VisualEditor requires which made it in to VE REL1_23 but not MW REL1_23. I'll try to find the right version and propose a backport for MW 1.23.1.
Actually, I jumped the gun here – happily the dependency was the other way around, with the out of date code in VE rather than MediaWiki, so this should (fingers crossed) now be fixed. Sorry for the confusion, and hope it works for you now.
Yours,
Hi
On Tue 24-Jun-2014 at 11:21:33AM -0700, James Forrester wrote:
Actually, I jumped the gun here – happily the dependency was the other way around, with the out of date code in VE rather than MediaWiki, so this should (fingers crossed) now be fixed. Sorry for the confusion, and hope it works for you now.
Great, should I get a copy of VE via git to get the fixed version?
All the best
Chris
On 24 June 2014 13:00, Chris Croome chris@webarchitects.co.uk wrote:
Hi
On Tue 24-Jun-2014 at 11:21:33AM -0700, James Forrester wrote:
Actually, I jumped the gun here – happily the dependency was the other way around, with the out of date code in VE rather than MediaWiki, so this should (fingers crossed) now be fixed. Sorry for the confusion, and hope it works for you now.
Great, should I get a copy of VE via git to get the fixed version?
Yes. I will update the archive in the next day or so.
J.
Hi James
On Tue 24-Jun-2014 at 10:58:51AM -0700, James Forrester wrote:
I'll try to find the right version and propose a backport for MW 1.23.1.
I just tried upgrading to 1.23.1 but this didn't solve the issue, switching to the git version of VE as per:
- https://www.mediawiki.org/wiki/Extension:VisualEditor#Download
did result in a working VE.
Thanks for your help.
All the best
Chris
wikitext-l@lists.wikimedia.org